You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openjpa.apache.org by "Kevin Sutter (JIRA)" <ji...@apache.org> on 2010/01/18 21:18:54 UTC

[jira] Created: (OPENJPA-1469) Turn on DataCache by default

Turn on DataCache by default
----------------------------

                 Key: OPENJPA-1469
                 URL: https://issues.apache.org/jira/browse/OPENJPA-1469
             Project: OpenJPA
          Issue Type: Improvement
          Components: datacache
    Affects Versions: 2.0.0-M3, 2.0.0-M2, 2.0.0-M1, 2.0.0-M4
            Reporter: Kevin Sutter
             Fix For: 2.0.0


I'm proposing that we change the default behavior for the DataCache.  Currently, the DataCache is turned off by default.  Our competition is turning on their L2 cache by default.  Thus, out-of-the-box comparisons are killing us.  We have to explain the difference, get them to change the configuration one way or the other for apples-to-apples comparisons, and then re-run the benchmark.  By that time, it's too late.  We already lost.

Due to the upcoming 2.0.0 release, it seems like a good time to change this default.  Please comment directly to this JIRA.

Thanks,
Kevin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OPENJPA-1469) Turn on DataCache by default

Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/OPENJPA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803049#action_12803049 ] 

Kevin Sutter commented on OPENJPA-1469:
---------------------------------------

This exercise is uncovering a few things which may make this "simple change" unattainable before the 2.0 release...

To turn on the L2 cache by default, we need to set the following default values for best performance and functionality:

openjpa.DataCache = true
openjpa.QueryCache = false
openjpa.RemoteCommitProvider = sjvm

Setting the RemoteCommitProvider to sjvm by default identifies that the Broker is no longer Serializable and, thus, fails those tests.

To temporarily get around this situation, I changed _provider in RemoteCommitEventManager to transient to allow for Serialization.  This cleared up 16 of the errors.  But, this is not a proper fix since the RemoteCommitEventManager is not transient in the OpenJPAConfiguration object.  And, the RemoteCommitEventManager depends on the RemoteCommitProvider to function properly.  So, maybe we need to make the RemoteCommitProvider Serializable...  More investigation required.

When I set openjpa.QueryCache to false, I found a few tests that were dependent on this being "on" by default.  These were the TestCacheMode* tests and the TestBulkJPQLAndDataCache tests.  I can update these tests.

There were also a few WriteBehind testcases that were failing with these settings.  Since this function doesn't look ready for a 2.0 release, I can disable these tests for now...

I still have to work through the remaining issues with setting the DataCache to "true"...

Bottom line is that the only change that we might be able to include in the 2.0 release is to turn the QueryCache "off" by default.  I'll post more when I know more...  Or, when Donald pulls the plug on the 2.0 release...

Kevin

> Turn on DataCache by default
> ----------------------------
>
>                 Key: OPENJPA-1469
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1469
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: datacache
>    Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3, 2.0.0-M4
>            Reporter: Kevin Sutter
>            Assignee: Kevin Sutter
>             Fix For: 2.0.0
>
>
> I'm proposing that we change the default behavior for the DataCache.  Currently, the DataCache is turned off by default.  Our competition is turning on their L2 cache by default.  Thus, out-of-the-box comparisons are killing us.  We have to explain the difference, get them to change the configuration one way or the other for apples-to-apples comparisons, and then re-run the benchmark.  By that time, it's too late.  We already lost.
> Due to the upcoming 2.0.0 release, it seems like a good time to change this default.  Please comment directly to this JIRA.
> Thanks,
> Kevin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (OPENJPA-1469) Turn on DataCache by default

Posted by "Kevin Sutter (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/OPENJPA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Sutter reassigned OPENJPA-1469:
-------------------------------------

    Assignee: Kevin Sutter

> Turn on DataCache by default
> ----------------------------
>
>                 Key: OPENJPA-1469
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1469
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: datacache
>    Affects Versions: 2.0.0-M1, 2.0.0-M2, 2.0.0-M3, 2.0.0-M4
>            Reporter: Kevin Sutter
>            Assignee: Kevin Sutter
>             Fix For: 2.0.0
>
>
> I'm proposing that we change the default behavior for the DataCache.  Currently, the DataCache is turned off by default.  Our competition is turning on their L2 cache by default.  Thus, out-of-the-box comparisons are killing us.  We have to explain the difference, get them to change the configuration one way or the other for apples-to-apples comparisons, and then re-run the benchmark.  By that time, it's too late.  We already lost.
> Due to the upcoming 2.0.0 release, it seems like a good time to change this default.  Please comment directly to this JIRA.
> Thanks,
> Kevin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.