You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/07 05:21:51 UTC
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7101
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
[catalog_manager_tsk-itest] removed mem acc bug workaround
KUDU-1294 is fixed now, so it's possible to remove the workaround
for the memory accounting bug. Before KUDU-1294 was fixed, the
workaround was necessary because the test crashed sometimes due
DCHECK() firing in the destructor of the MemTracker class.
Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
---
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/7101/1
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [catalog manager tsk-itest] remove KUDU-1294 workaround
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [catalog_manager_tsk-itest] remove KUDU-1294 workaround
......................................................................
[catalog_manager_tsk-itest] remove KUDU-1294 workaround
KUDU-1294 is fixed now, so it's possible to remove the workaround
for the memory accounting bug. Before KUDU-1294 was fixed, the
workaround was necessary because the test crashed sometimes due
DCHECK() firing in the destructor of the MemTracker class.
Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Reviewed-on: http://gerrit.cloudera.org:8080/7101
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7101/1//COMMIT_MSG
Commit Message:
PS1, Line 10:
> nit: extra space
Done
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [catalog manager tsk-itest] remove KUDU-1294 workaround
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [catalog_manager_tsk-itest] remove KUDU-1294 workaround
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [catalog manager tsk-itest] remove KUDU-1294 workaround
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#3).
Change subject: [catalog_manager_tsk-itest] remove KUDU-1294 workaround
......................................................................
[catalog_manager_tsk-itest] remove KUDU-1294 workaround
KUDU-1294 is fixed now, so it's possible to remove the workaround
for the memory accounting bug. Before KUDU-1294 was fixed, the
workaround was necessary because the test crashed sometimes due
DCHECK() firing in the destructor of the MemTracker class.
Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
---
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/7101/3
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
[catalog_manager_tsk-itest] removed mem acc bug workaround
KUDU-1294 is fixed now, so it's possible to remove the workaround
for the memory accounting bug. Before KUDU-1294 was fixed, the
workaround was necessary because the test crashed sometimes due
DCHECK() firing in the destructor of the MemTracker class.
Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
---
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/7101/2
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
Patch Set 2: Verified+1
Unrelated flake in org.apache.kudu.client.ITClient.test
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7101/2//COMMIT_MSG
Commit Message:
Line 7: [catalog_manager_tsk-itest] removed mem acc bug workaround
nit: I didn't know what "acc" was when I first read this. Can you expand the abbreviation?
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7101/1//COMMIT_MSG
Commit Message:
PS1, Line 10:
nit: extra space
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [catalog manager tsk-itest] removed mem acc bug workaround
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [catalog_manager_tsk-itest] removed mem acc bug workaround
......................................................................
Patch Set 1: Verified+1
Unrelated flakes in MultiThreadedTabletTest/4.DeleteAndReinsert
--
To view, visit http://gerrit.cloudera.org:8080/7101
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No