[GitHub] [spark] zhengruifeng commented on a diff in pull request #37335: [SPARK-39895][PYTHON] Support multiple column drop

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #37335:
URL: https://github.com/apache/spark/pull/37335#discussion_r938728719


##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala:
##########
@@ -826,6 +826,16 @@ class DataFrameSuite extends QueryTest
     assert(df.schema.map(_.name) === Seq("key", "value"))
   }
 
+  test("drop two column references") {

Review Comment:
   ```suggestion
     test("SPARK-39895: drop two column references") {
   ```



##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -87,6 +87,21 @@ def test_help_command(self):
         pydoc.render_doc(df.foo)
         pydoc.render_doc(df.take(1))
 
+    def test_drop(self):
+        df = self.spark.createDataFrame([("A", 50, "Y"), ("B", 60, "Y")], ["name", "age", "active"])
+

Review Comment:
   I think we can remove these empty lines here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org