You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/02/11 16:53:14 UTC
[GitHub] [singa] dcslin opened a new pull request #597: added tensor index
selector
dcslin opened a new pull request #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] dcslin commented on issue #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
dcslin commented on issue #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597#issuecomment-591833963
this is ready for merge, which is required in ONNX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] nudles merged pull request #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] dcslin commented on issue #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
dcslin commented on issue #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597#issuecomment-584736729
Hi @joddiy , regarding Conv padding, i understand that the missing part is the index selection, e.g.`tensor1[:,:,1:,1:]`, which is added in this PR.
Let me know if further info is required.
@nudles , FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] dcslin commented on issue #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
dcslin commented on issue #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597#issuecomment-588006821
> Hi, @dcslin, for the backward of CNN, I guess I should firstly pad the dy as its shape same with the shape before index selection. So, I need a function that can add one column and row at the end or start of the matrix. For example, for "SAME_UPPER" mode, and output shape of [3,3,32,32], I need to pad one column and one row at the end of the dy to make the shape as [3,3,32,32].
hi could it be done in reverse way? add extra padding and make it symmetrical, and trim off one column by using the selection[].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] joddiy commented on issue #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
joddiy commented on issue #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597#issuecomment-587963518
Hi, @dcslin, for the backward of CNN, I guess I should firstly pad the dy as its shape same with the shape before index selection. So, I need a function that can add one column and row at the end or start of the matrix. For example, for "SAME_UPPER" mode, and output shape of [3,3,32,32], I need to pad one column and one row at the end of the dy to make the shape as [3,3,32,32].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] joddiy commented on issue #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
joddiy commented on issue #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597#issuecomment-588017006
> > Hi, @dcslin, for the backward of CNN, I guess I should firstly pad the dy as its shape same with the shape before index selection. So, I need a function that can add one column and row at the end or start of the matrix. For example, for "SAME_UPPER" mode, and output shape of [3,3,32,32], I need to pad one column and one row at the end of the dy to make the shape as [3,3,32,32].
>
> hi could it be done in reverse way? add extra padding and make it symmetrical, and trim off one column by using the selection[].
sure, and how to add extra padding? can use singa.add_column and add_row?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa] joddiy commented on issue #597: added tensor index selector
Posted by GitBox <gi...@apache.org>.
joddiy commented on issue #597: added tensor index selector
URL: https://github.com/apache/singa/pull/597#issuecomment-584737990
thanks, shicong, I'll try it ASAP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services