You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Laurent Goujon (JIRA)" <ji...@apache.org> on 2017/01/03 22:48:58 UTC
[jira] [Comment Edited] (CALCITE-1557) Add missing support for
numerical JDBC functions
[ https://issues.apache.org/jira/browse/CALCITE-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796448#comment-15796448 ]
Laurent Goujon edited comment on CALCITE-1557 at 1/3/17 10:48 PM:
------------------------------------------------------------------
Small question about {{FLOOR}} and {{CEILING}}: in which list of tokens should these one be? Not adding to CommonNonReservedKeywords or ReservedFunctionNames obviously doesn't work ({{{fn CEILING(...)}} would fail parsing), but adding it to CommonNonReservedKeywords will make some of {{SqlAdvisorTest}} to fail because the list of suggestion would not have {{FLOOR}} or {{CEILING}}.
Or maybe (probably?) I totally misunderstood what these lists are for?
was (Author: laurentgo):
Small question about {{FLOOR}} and {{CEILING}}: in which list of tokens should these one be? Not adding to CommonNonReservedKeywords or ReservedFunctionNames obviously doesn't work ({{{fn CEILING(...)}}} would fail parsing), but adding it to CommonNonReservedKeywords will make some of {{SqlAdvisorTest} to fail because the list of suggestion would not have {{FLOOR}} or {{CEILING}}.
Or maybe (probably?) I totally misunderstood what these lists are for?
> Add missing support for numerical JDBC functions
> ------------------------------------------------
>
> Key: CALCITE-1557
> URL: https://issues.apache.org/jira/browse/CALCITE-1557
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Laurent Goujon
> Assignee: Julian Hyde
> Priority: Minor
>
> Calcite advertises support for all numerical functions but only have implementations for some (ABS, EXP, LOG, LOG10, MOD, POWER)
> It would be a nice-to have to extend the support so that all functions are covered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)