You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/19 07:37:40 UTC

[GitHub] [pulsar] RobertIndie commented on a change in pull request #12872: [Broker] Support create subscription by specifying the earliest or latest position.

RobertIndie commented on a change in pull request #12872:
URL: https://github.com/apache/pulsar/pull/12872#discussion_r752920821



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java
##########
@@ -45,6 +45,18 @@ private MessageIdImpl() {
         this(-1, -1, -1);
     }
 
+    // Private constructor used only for json deserialization
+    private MessageIdImpl(String position) {

Review comment:
       Yes. I think we can throw an exception in the constructor to tell the user the position is invalid.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org