You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/04/29 09:58:51 UTC
[Impala-ASF-CR] Started working on benchmarks on parquet delta encoding.
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13154
Change subject: Started working on benchmarks on parquet delta encoding.
......................................................................
Started working on benchmarks on parquet delta encoding.
Change-Id: Id903b3e9f924b6aaed9367a56b78618b35f2c9f2
---
M be/src/benchmarks/CMakeLists.txt
A be/src/benchmarks/parquet-delta-benchmark.cc
M be/src/exec/parquet/parquet-delta-encoder.h
M be/src/util/bit-packing.inline.h
4 files changed, 366 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/13154/1
--
To view, visit http://gerrit.cloudera.org:8080/13154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id903b3e9f924b6aaed9367a56b78618b35f2c9f2
Gerrit-Change-Number: 13154
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] Started working on benchmarks on parquet delta encoding.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13154 )
Change subject: Started working on benchmarks on parquet delta encoding.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13154/1/be/src/exec/parquet/parquet-delta-encoder.h
File be/src/exec/parquet/parquet-delta-encoder.h:
http://gerrit.cloudera.org:8080/#/c/13154/1/be/src/exec/parquet/parquet-delta-encoder.h@115
PS1, Line 115: const int header_size = HeaderSize(most_negative_first_value, MAX_TOTAL_VALUE_COUNT);
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/13154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id903b3e9f924b6aaed9367a56b78618b35f2c9f2
Gerrit-Change-Number: 13154
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:12:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Started working on benchmarks on parquet delta encoding.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13154 )
Change subject: Started working on benchmarks on parquet delta encoding.
......................................................................
Patch Set 1:
No Builds Executed
--
To view, visit http://gerrit.cloudera.org:8080/13154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id903b3e9f924b6aaed9367a56b78618b35f2c9f2
Gerrit-Change-Number: 13154
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:29:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Started working on benchmarks on parquet delta encoding.
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has abandoned this change. ( http://gerrit.cloudera.org:8080/13154 )
Change subject: Started working on benchmarks on parquet delta encoding.
......................................................................
Abandoned
Opened by mistake.
--
To view, visit http://gerrit.cloudera.org:8080/13154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id903b3e9f924b6aaed9367a56b78618b35f2c9f2
Gerrit-Change-Number: 13154
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>