You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/07/02 18:12:22 UTC
[GitHub] [zookeeper] enixon commented on a change in pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip sending some transactions t…
enixon commented on a change in pull request #972: ZOOKEEPER-2418: txnlog diff sync can skip sending some transactions t…
URL: https://github.com/apache/zookeeper/pull/972#discussion_r299614225
##########
File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java
##########
@@ -487,60 +487,6 @@ public void testNewEpochZxid() throws Exception {
}
- /**
- * Test cases when learner has new-epcoh zxid
- * (zxid & 0xffffffffL) == 0;
- */
- @Test
- public void testNewEpochZxidWithTxnlogOnly() throws Exception {
Review comment:
The structure of this test requires inserting gaps in the txn log in order to work, indeed it is testing what response the learner gets when it has a gap. There's no way to rescue the test after this PR adds protection against syncing on top of such a gap so I'm dropping it (in favor of adding the test farther below that tests behavior on a gap directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services