You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/02/07 13:46:03 UTC
[GitHub] [superset] kgabryje opened a new pull request, #23020: fix(explore): Enable saving metric after changing title
kgabryje opened a new pull request, #23020:
URL: https://github.com/apache/superset/pull/23020
### SUMMARY
When user added an adhoc metric with a custom title, saved it, and then tried to only change the title, the "Save" button remained greyed out. This PR fixes that bug.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="374" alt="image" src="https://user-images.githubusercontent.com/15073128/217261790-512686ac-ea3c-445c-8082-480c7ddb14a1.png">
After:
<img width="376" alt="image" src="https://user-images.githubusercontent.com/15073128/217261738-cb02b323-d7bc-491b-999b-524c4937f5e7.png">
### TESTING INSTRUCTIONS
1. Create an adhoc metric, give it a custom name and save
2. Open the adhoc metric popover to edit the created metric
3. Change only the title
4. "Save" button should be enabled
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #23020: fix(explore): Enable saving metric after changing title
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #23020:
URL: https://github.com/apache/superset/pull/23020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org