You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/16 18:19:27 UTC

[GitHub] [superset] betodealmeida opened a new pull request #19216: chore: refactor import command

betodealmeida opened a new pull request #19216:
URL: https://github.com/apache/superset/pull/19216


   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Refactor two methods from `ImportModelsCommand` into functions, so they can be reused later on a new command.
   
   This depends on https://github.com/apache/superset/pull/19215.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   N/A
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (377fba6) into [master](https://codecov.io/gh/apache/superset/commit/d01fdad1d8da740af95e32adf2c9fc4bd1da7db5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d01fdad) will **increase** coverage by `14.36%`.
   > The diff coverage is `97.14%`.
   
   > :exclamation: Current head 377fba6 differs from pull request most recent head 625b774. Consider uploading reports for the commit 625b774 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #19216       +/-   ##
   ===========================================
   + Coverage   52.03%   66.40%   +14.36%     
   ===========================================
     Files        1646     1646               
     Lines       63635    63640        +5     
     Branches     6475     6475               
   ===========================================
   + Hits        33112    42257     +9145     
   + Misses      28843    19703     -9140     
     Partials     1680     1680               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.88% <97.14%> (?)` | |
   | postgres | `81.92% <97.14%> (?)` | |
   | presto | `?` | |
   | python | `82.01% <97.14%> (+29.22%)` | :arrow_up: |
   | sqlite | `81.67% <97.14%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `93.50% <96.87%> (+50.02%)` | :arrow_up: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.64% <100.00%> (+62.93%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.79% <0.00%> (+0.31%)` | :arrow_up: |
   | [superset/common/utils/query\_cache\_manager.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzL3F1ZXJ5X2NhY2hlX21hbmFnZXIucHk=) | `89.41% <0.00%> (+1.17%)` | :arrow_up: |
   | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `90.72% <0.00%> (+1.71%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.90% <0.00%> (+2.43%)` | :arrow_up: |
   | [superset/charts/data/commands/get\_data\_command.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvY29tbWFuZHMvZ2V0X2RhdGFfY29tbWFuZC5weQ==) | `100.00% <0.00%> (+3.70%)` | :arrow_up: |
   | [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `96.00% <0.00%> (+4.00%)` | :arrow_up: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.68% <0.00%> (+4.13%)` | :arrow_up: |
   | ... and [284 more](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d01fdad...625b774](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e97df46) into [export_related_flag](https://codecov.io/gh/apache/superset/commit/30c97ad5bfe1dc9b074efc294c647c32fdd05fe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c97ad) will **increase** coverage by `0.00%`.
   > The diff coverage is `91.95%`.
   
   > :exclamation: Current head e97df46 differs from pull request most recent head 625b774. Consider uploading reports for the commit 625b774 to get more accurate results
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           export_related_flag   #19216   +/-   ##
   ====================================================
     Coverage                66.55%   66.55%           
   ====================================================
     Files                     1646     1646           
     Lines                    63617    63627   +10     
     Branches                  6471     6471           
   ====================================================
   + Hits                     42339    42348    +9     
   - Misses                   19600    19601    +1     
     Partials                  1678     1678           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `52.52% <20.68%> (-0.02%)` | :arrow_down: |
   | mysql | `81.88% <91.95%> (+<0.01%)` | :arrow_up: |
   | postgres | `81.92% <91.95%> (+<0.01%)` | :arrow_up: |
   | presto | `52.36% <20.68%> (-0.02%)` | :arrow_down: |
   | python | `82.35% <91.95%> (+<0.01%)` | :arrow_up: |
   | sqlite | `81.67% <91.95%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `84.93% <71.42%> (-0.99%)` | :arrow_down: |
   | [superset/datasets/commands/export.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `87.75% <84.61%> (+0.25%)` | :arrow_up: |
   | [superset/queries/saved\_queries/commands/export.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.44% <84.61%> (+0.15%)` | :arrow_up: |
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `93.50% <96.87%> (+2.20%)` | :arrow_up: |
   | [superset/charts/commands/export.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `94.11% <100.00%> (ø)` | |
   | [superset/commands/export/models.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhwb3J0L21vZGVscy5weQ==) | `96.96% <100.00%> (ø)` | |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.64% <100.00%> (-0.48%)` | :arrow_down: |
   | [superset/databases/commands/export.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `91.48% <100.00%> (+0.18%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30c97ad...625b774](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida merged pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #19216:
URL: https://github.com/apache/superset/pull/19216


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (625b774) into [master](https://codecov.io/gh/apache/superset/commit/d01fdad1d8da740af95e32adf2c9fc4bd1da7db5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d01fdad) will **increase** coverage by `14.37%`.
   > The diff coverage is `97.14%`.
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #19216       +/-   ##
   ===========================================
   + Coverage   52.03%   66.40%   +14.37%     
   ===========================================
     Files        1646     1646               
     Lines       63635    63640        +5     
     Branches     6475     6475               
   ===========================================
   + Hits        33112    42263     +9151     
   + Misses      28843    19697     -9146     
     Partials     1680     1680               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `52.52% <14.28%> (-0.01%)` | :arrow_down: |
   | presto | `52.36% <14.28%> (-0.01%)` | :arrow_down: |
   | python | `82.03% <97.14%> (+29.24%)` | :arrow_up: |
   | sqlite | `81.67% <97.14%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `92.20% <96.87%> (+48.72%)` | :arrow_up: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.64% <100.00%> (+62.93%)` | :arrow_up: |
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.79% <0.00%> (+0.31%)` | :arrow_up: |
   | [superset/common/utils/query\_cache\_manager.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3V0aWxzL3F1ZXJ5X2NhY2hlX21hbmFnZXIucHk=) | `89.41% <0.00%> (+1.17%)` | :arrow_up: |
   | [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `90.72% <0.00%> (+1.71%)` | :arrow_up: |
   | [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `93.90% <0.00%> (+2.43%)` | :arrow_up: |
   | [superset/charts/data/commands/get\_data\_command.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvY29tbWFuZHMvZ2V0X2RhdGFfY29tbWFuZC5weQ==) | `100.00% <0.00%> (+3.70%)` | :arrow_up: |
   | [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `96.00% <0.00%> (+4.00%)` | :arrow_up: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `60.68% <0.00%> (+4.13%)` | :arrow_up: |
   | [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `91.48% <0.00%> (+4.25%)` | :arrow_up: |
   | ... and [282 more](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d01fdad...625b774](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e97df46) into [export_related_flag](https://codecov.io/gh/apache/superset/commit/db3f68dddb012cf8f43699359aaeb09183584af3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db3f68d) will **increase** coverage by `0.00%`.
   > The diff coverage is `97.14%`.
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           export_related_flag   #19216   +/-   ##
   ====================================================
     Coverage                66.55%   66.55%           
   ====================================================
     Files                     1646     1646           
     Lines                    63622    63627    +5     
     Branches                  6471     6471           
   ====================================================
   + Hits                     42343    42348    +5     
     Misses                   19601    19601           
     Partials                  1678     1678           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `52.52% <14.28%> (-0.01%)` | :arrow_down: |
   | mysql | `81.88% <97.14%> (+<0.01%)` | :arrow_up: |
   | postgres | `81.92% <97.14%> (+<0.01%)` | :arrow_up: |
   | presto | `52.36% <14.28%> (-0.01%)` | :arrow_down: |
   | python | `82.35% <97.14%> (+<0.01%)` | :arrow_up: |
   | sqlite | `81.67% <97.14%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `93.50% <96.87%> (+2.20%)` | :arrow_up: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.64% <100.00%> (-0.48%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [db3f68d...e97df46](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e97df46) into [export_related_flag](https://codecov.io/gh/apache/superset/commit/db3f68dddb012cf8f43699359aaeb09183584af3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db3f68d) will **increase** coverage by `0.00%`.
   > The diff coverage is `97.14%`.
   
   ```diff
   @@                 Coverage Diff                  @@
   ##           export_related_flag   #19216   +/-   ##
   ====================================================
     Coverage                66.55%   66.55%           
   ====================================================
     Files                     1646     1646           
     Lines                    63622    63627    +5     
     Branches                  6471     6471           
   ====================================================
   + Hits                     42343    42348    +5     
     Misses                   19601    19601           
     Partials                  1678     1678           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `52.52% <14.28%> (-0.01%)` | :arrow_down: |
   | mysql | `81.88% <97.14%> (+<0.01%)` | :arrow_up: |
   | postgres | `81.92% <97.14%> (+<0.01%)` | :arrow_up: |
   | presto | `52.36% <14.28%> (-0.01%)` | :arrow_down: |
   | python | `82.35% <97.14%> (+<0.01%)` | :arrow_up: |
   | sqlite | `81.67% <97.14%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `93.50% <96.87%> (+2.20%)` | :arrow_up: |
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `94.64% <100.00%> (-0.48%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [db3f68d...e97df46](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (625b774) into [master](https://codecov.io/gh/apache/superset/commit/d01fdad1d8da740af95e32adf2c9fc4bd1da7db5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d01fdad) will **increase** coverage by `0.20%`.
   > The diff coverage is `14.28%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #19216      +/-   ##
   ==========================================
   + Coverage   51.82%   52.03%   +0.20%     
   ==========================================
     Files        1646     1646              
     Lines       63635    63640       +5     
     Branches     6475     6475              
   ==========================================
   + Hits        32978    33114     +136     
   + Misses      28977    28846     -131     
     Partials     1680     1680              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `52.52% <14.28%> (?)` | |
   | presto | `52.36% <14.28%> (-0.01%)` | :arrow_down: |
   | python | `52.79% <14.28%> (+0.42%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `42.85% <0.00%> (+11.14%)` | :arrow_up: |
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `31.16% <15.62%> (-12.31%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `55.83% <0.00%> (+0.12%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `72.71% <0.00%> (+0.57%)` | :arrow_up: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `61.32% <0.00%> (+0.69%)` | :arrow_up: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `62.43% <0.00%> (+2.17%)` | :arrow_up: |
   | [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `82.35% <0.00%> (+5.88%)` | :arrow_up: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `77.41% <0.00%> (+6.45%)` | :arrow_up: |
   | [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | `52.63% <0.00%> (+15.78%)` | :arrow_up: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `64.23% <0.00%> (+28.84%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d01fdad...625b774](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #19216: chore: refactor import command

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19216:
URL: https://github.com/apache/superset/pull/19216#issuecomment-1069406150


   # [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19216](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (625b774) into [master](https://codecov.io/gh/apache/superset/commit/d01fdad1d8da740af95e32adf2c9fc4bd1da7db5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d01fdad) will **decrease** coverage by `0.00%`.
   > The diff coverage is `14.28%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #19216      +/-   ##
   ==========================================
   - Coverage   52.03%   52.03%   -0.01%     
   ==========================================
     Files        1646     1646              
     Lines       63635    63640       +5     
     Branches     6475     6475              
   ==========================================
   + Hits        33112    33114       +2     
   - Misses      28843    28846       +3     
     Partials     1680     1680              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `52.52% <14.28%> (-0.01%)` | :arrow_down: |
   | presto | `52.36% <14.28%> (-0.01%)` | :arrow_down: |
   | python | `52.79% <14.28%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `42.85% <0.00%> (+11.14%)` | :arrow_up: |
   | [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19216/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `31.16% <15.62%> (-12.31%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d01fdad...625b774](https://codecov.io/gh/apache/superset/pull/19216?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org