You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2017/02/01 04:39:55 UTC
Re: Review Request 55712: Fact Schema change to support all update
periods in one storage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/#review163785
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 190)
<https://reviews.apache.org/r/55712/#comment235283>
Seems variable is not used, can be removed?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 347)
<https://reviews.apache.org/r/55712/#comment235284>
Why is timeLineKey storageTableName? And tableName is only constructed with fact and storage names?
- Amareshwari Sriramadasu
On Jan. 31, 2017, 1:53 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55712/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 1:53 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1386
> https://issues.apache.org/jira/browse/LENS-1386
>
>
> Repository: lens
>
>
> Description
> -------
>
> A new data structure XUpdatePeriodTableDescriptor is introduced which contains an update period and table descriptor. Now the XUpdatePeriods will contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd f438f48
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java adb6c92
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 6c9cde2
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 53cf8af
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java e21dc2a
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 8b10d1d
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 51fcb43
>
> Diff: https://reviews.apache.org/r/55712/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>