You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Fabriceli (via GitHub)" <gi...@apache.org> on 2023/02/08 02:46:58 UTC

[GitHub] [apisix-dashboard] Fabriceli opened a new pull request, #2731: feat: support consul discovery

Fabriceli opened a new pull request, #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731

   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Support Consul discovery
   
   **Related issues**
   
   [feat #2695](https://github.com/apache/apisix-dashboard/issues/2695)
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1447491944

   @bzp2010 @Baoyuantop Could you have a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on a diff in pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on code in PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#discussion_r1136475929


##########
web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js:
##########
@@ -154,6 +154,48 @@ context('Create Route with Service Discovery Upstream', () => {
     });
   });
 
+  it('should edit this route with Consul Service Discovery upstream', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    cy.get(selector.nameSelector).type(data.routeName);
+
+    cy.contains('Search').click();
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+
+    cy.contains('Nacos').should('exist');
+
+    // set another service discovery
+    cy.get(selector.discovery_type).click({ force: true });
+    cy.get(selector.selectItem).within(() => {
+      cy.contains('Consul').click();
+    });
+    cy.get(selector.service_name).clear().type(`another.${data.serviceName}`);
+
+    cy.contains('Next').click();
+    cy.contains('Next').click();
+    cy.contains('Submit').click();
+    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains('Goto List').click();
+    cy.url().should('contains', 'routes/list');
+
+    // check if the changes have been saved
+    cy.get(selector.nameSelector).type(data.routeName);
+    cy.contains('Search').click();
+
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+    // ensure it has already changed to edit page
+    cy.get(selector.name).should('value', data.routeName);

Review Comment:
   done



##########
web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js:
##########
@@ -154,6 +154,48 @@ context('Create Route with Service Discovery Upstream', () => {
     });
   });
 
+  it('should edit this route with Consul Service Discovery upstream', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    cy.get(selector.nameSelector).type(data.routeName);
+
+    cy.contains('Search').click();
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+
+    cy.contains('Nacos').should('exist');
+
+    // set another service discovery
+    cy.get(selector.discovery_type).click({ force: true });
+    cy.get(selector.selectItem).within(() => {
+      cy.contains('Consul').click();
+    });
+    cy.get(selector.service_name).clear().type(`another.${data.serviceName}`);
+
+    cy.contains('Next').click();
+    cy.contains('Next').click();
+    cy.contains('Submit').click();
+    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains('Goto List').click();
+    cy.url().should('contains', 'routes/list');
+
+    // check if the changes have been saved
+    cy.get(selector.nameSelector).type(data.routeName);
+    cy.contains('Search').click();
+
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+    // ensure it has already changed to edit page
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+    cy.get(selector.service_name).should('value', `another.${data.serviceName}`);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1475183254

   @Baoyuantop Please return CI, I add `consul` check, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1479768889

   @Baoyuantop Fixed the CI error, please return CI, thanks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1422658524

   return ci
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on a diff in pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on code in PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#discussion_r1141319058


##########
web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js:
##########
@@ -154,6 +154,48 @@ context('Create Route with Service Discovery Upstream', () => {
     });
   });
 
+  it('should edit this route with Consul Service Discovery upstream', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    cy.get(selector.nameSelector).type(data.routeName);
+
+    cy.contains('Search').click();
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+
+    cy.contains('Nacos').should('exist');
+
+    // set another service discovery
+    cy.get(selector.discovery_type).click({ force: true });
+    cy.get(selector.selectItem).within(() => {
+      cy.contains('Consul').click();
+    });
+    cy.get(selector.service_name).clear().type(`another.${data.serviceName}`);
+
+    cy.contains('Next').click();
+    cy.contains('Next').click();
+    cy.contains('Submit').click();
+    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains('Goto List').click();
+    cy.url().should('contains', 'routes/list');
+
+    // check if the changes have been saved
+    cy.get(selector.nameSelector).type(data.routeName);
+    cy.contains('Search').click();
+
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+    // ensure it has already changed to edit page
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+    cy.get(selector.service_name).should('value', `another.${data.serviceName}`);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2731: feat: support consul discovery

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1421961088

   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2731](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95873b4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4d26409e9f7819e20a65ff7ab5b877dedca82cdf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d26409) will **decrease** coverage by `8.43%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 95873b4 differs from pull request most recent head 7b3119b. Consider uploading reports for the commit 7b3119b to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2731      +/-   ##
   ==========================================
   - Coverage   76.40%   67.98%   -8.43%     
   ==========================================
     Files         139       39     -100     
     Lines        3759     1040    -2719     
     Branches      877      268     -609     
   ==========================================
   - Hits         2872      707    -2165     
   + Misses        887      333     -554     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `67.98% <ø> (-8.43%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `19.67% <0.00%> (-57.38%)` | :arrow_down: |
   | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `50.00% <0.00%> (-32.15%)` | :arrow_down: |
   | [web/src/components/PanelSection/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BhbmVsU2VjdGlvbi9pbmRleC50c3g=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `69.69% <0.00%> (-21.22%)` | :arrow_down: |
   | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `73.17% <0.00%> (-19.52%)` | :arrow_down: |
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `82.00% <0.00%> (-17.00%)` | :arrow_down: |
   | [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | `69.23% <0.00%> (-15.39%)` | :arrow_down: |
   | [web/src/app.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9hcHAudHN4) | `87.87% <0.00%> (-12.13%)` | :arrow_down: |
   | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `71.11% <0.00%> (-11.12%)` | :arrow_down: |
   | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `64.48% <0.00%> (-10.93%)` | :arrow_down: |
   | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2731?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2731: feat: support consul discovery

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#discussion_r1135443749


##########
web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js:
##########
@@ -154,6 +154,48 @@ context('Create Route with Service Discovery Upstream', () => {
     });
   });
 
+  it('should edit this route with Consul Service Discovery upstream', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    cy.get(selector.nameSelector).type(data.routeName);
+
+    cy.contains('Search').click();
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+
+    cy.contains('Nacos').should('exist');
+
+    // set another service discovery
+    cy.get(selector.discovery_type).click({ force: true });
+    cy.get(selector.selectItem).within(() => {
+      cy.contains('Consul').click();
+    });
+    cy.get(selector.service_name).clear().type(`another.${data.serviceName}`);
+
+    cy.contains('Next').click();
+    cy.contains('Next').click();
+    cy.contains('Submit').click();
+    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains('Goto List').click();
+    cy.url().should('contains', 'routes/list');
+
+    // check if the changes have been saved
+    cy.get(selector.nameSelector).type(data.routeName);
+    cy.contains('Search').click();
+
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+    // ensure it has already changed to edit page
+    cy.get(selector.name).should('value', data.routeName);

Review Comment:
   ```suggestion
       cy.get(selector.name).should('have.value', data.routeName);
   ```



##########
web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js:
##########
@@ -154,6 +154,48 @@ context('Create Route with Service Discovery Upstream', () => {
     });
   });
 
+  it('should edit this route with Consul Service Discovery upstream', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    cy.get(selector.nameSelector).type(data.routeName);
+
+    cy.contains('Search').click();
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+
+    cy.contains('Nacos').should('exist');
+
+    // set another service discovery
+    cy.get(selector.discovery_type).click({ force: true });
+    cy.get(selector.selectItem).within(() => {
+      cy.contains('Consul').click();
+    });
+    cy.get(selector.service_name).clear().type(`another.${data.serviceName}`);
+
+    cy.contains('Next').click();
+    cy.contains('Next').click();
+    cy.contains('Submit').click();
+    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains('Goto List').click();
+    cy.url().should('contains', 'routes/list');
+
+    // check if the changes have been saved
+    cy.get(selector.nameSelector).type(data.routeName);
+    cy.contains('Search').click();
+
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+    // ensure it has already changed to edit page
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+    cy.get(selector.service_name).should('value', `another.${data.serviceName}`);

Review Comment:
   Also need to check Discovery Type is Consul
   



##########
web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js:
##########
@@ -154,6 +154,48 @@ context('Create Route with Service Discovery Upstream', () => {
     });
   });
 
+  it('should edit this route with Consul Service Discovery upstream', function () {
+    cy.visit('/');
+    cy.contains('Route').click();
+    cy.get(selector.nameSelector).type(data.routeName);
+
+    cy.contains('Search').click();
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+
+    cy.contains('Nacos').should('exist');
+
+    // set another service discovery
+    cy.get(selector.discovery_type).click({ force: true });
+    cy.get(selector.selectItem).within(() => {
+      cy.contains('Consul').click();
+    });
+    cy.get(selector.service_name).clear().type(`another.${data.serviceName}`);
+
+    cy.contains('Next').click();
+    cy.contains('Next').click();
+    cy.contains('Submit').click();
+    cy.contains(data.submitSuccess).should('be.visible');
+    cy.contains('Goto List').click();
+    cy.url().should('contains', 'routes/list');
+
+    // check if the changes have been saved
+    cy.get(selector.nameSelector).type(data.routeName);
+    cy.contains('Search').click();
+
+    cy.contains(data.routeName).siblings().contains('Configure').click();
+    // ensure it has already changed to edit page
+    cy.get(selector.name).should('value', data.routeName);
+    cy.contains('Next').click({
+      force: true,
+    });
+    cy.get(selector.service_name).should('value', `another.${data.serviceName}`);

Review Comment:
   ```suggestion
       cy.get(selector.service_name).should('have.value', `another.${data.serviceName}`);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2731: feat: support consul discovery

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1467196016

   > @Baoyuantop please talk a look at this PR, thanks
   
   Sorry for taking so long to reply, will deal with it today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1475630617

   Return CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1464723432

   @Baoyuantop please talk a look at this PR, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2731: feat: support consul discovery

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1452792319

   > > Codes LGTM, we need to add an E2E test for it. You can refer to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js
   > 
   > Could you show me about how to run e2e test in local? Not found any command in Makefile
   
   We use Cypress for the E2E test, you can refer to https://docs.cypress.io/guides/getting-started/opening-the-app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1482102227

   @guoqqqi @LiteSun @SkyeYoung take a look at this PR, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1436988327

   @bzp2010 Cloud you have a look ath this PR? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1454332322

   > > > Codes LGTM, we need to add an E2E test for it. You can refer to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js
   > > 
   > > 
   > > Could you show me about how to run e2e test in local? Not found any command in Makefile
   > 
   > We use Cypress for the E2E test, you can refer to https://docs.cypress.io/guides/getting-started/opening-the-app
   
   Please return CI to run the e2e test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1475647916

   @Baoyuantop Could you return the CI to re-run the workflows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1480496510

   @Baoyuantop take a look at this PR, thanks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop merged pull request #2731: feat: support consul discovery

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop merged PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1483767423

   /merge
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1455933742

   @Baoyuantop the e2e test is not stable, i did not changed any code in `data-loader-import.cy.js`; please return ci again, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] todorinskiz commented on pull request #2731: feat: support consul discovery

Posted by "todorinskiz (via GitHub)" <gi...@apache.org>.
todorinskiz commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1446903675

   Thanks @Fabriceli for implementing this!
   It's funny that a [2000 lines PR](https://github.com/apache/apisix/pull/8380/files) is held up by a 5 line PR :smile: .. Looking forward to this feature!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2731: feat: support consul discovery

Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1447493337

   > @bzp2010 @Baoyuantop Could you have a look at this PR?
   
   Sorry for the late reply, I will review it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1452786964

   > Codes LGTM, we need to add an E2E test for it. You can refer to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/e2e/route/create-route-with-service-discovery-upstream.cy.js
   
   Could you show me about how to run e2e test in local? Not found any command in Makefile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1483648806

   @Baoyuantop could you merge this PR, I have no permission to merge🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on PR #2731:
URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1421908384

   @guoqqqi @bzp2010 could you have a look at this PR, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org