You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/05 09:01:52 UTC
[GitHub] [inlong] Oneal65 opened a new pull request, #5374: [INLONG-5205][Sort] Add reporting metrics for Elasticsearch 6 connector
Oneal65 opened a new pull request, #5374:
URL: https://github.com/apache/inlong/pull/5374
- Fixes #5205
### Motivation
Add reporting metrics for Elasticsearch 6 connector
### Modifications
Add reporting metrics for Elasticsearch 6 connector
### some reference
there is a pr in flink-connector: https://github.com/apache/flink/pull/8568
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5374: [INLONG-5205][Sort] Add reporting metrics for Elasticsearch 6 connector
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5374:
URL: https://github.com/apache/inlong/pull/5374#discussion_r941261464
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/ElasticsearchSinkBase.java:
##########
@@ -263,8 +265,23 @@ public void disableFlushOnCheckpoint() {
@Override
public void open(Configuration parameters) throws Exception {
client = callBridge.createClient(userConfig);
+ metricData = new MetricData(getRuntimeContext().getMetricGroup());
Review Comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5374: [INLONG-5205][Sort] Add reporting metrics for Elasticsearch 6 connector
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5374:
URL: https://github.com/apache/inlong/pull/5374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5374: [INLONG-5205][Sort] Add reporting metrics for Elasticsearch 6 connector
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5374:
URL: https://github.com/apache/inlong/pull/5374#discussion_r941949580
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/ElasticsearchOptions.java:
##########
@@ -155,8 +144,23 @@ public enum BackOffType {
.withDescription(
"The format must produce a valid JSON document. "
+ "Please refer to the documentation on formats for more details.");
+ public static final ConfigOption<String> INLONG_METRIC =
Review Comment:
inlong metric is defined in inlongMetric interface, can just use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #5374: [INLONG-5205][Sort] Add reporting metrics for Elasticsearch 6 connector
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5374:
URL: https://github.com/apache/inlong/pull/5374#discussion_r941076859
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/ElasticsearchSinkBase.java:
##########
@@ -263,8 +265,23 @@ public void disableFlushOnCheckpoint() {
@Override
public void open(Configuration parameters) throws Exception {
client = callBridge.createClient(userConfig);
+ metricData = new MetricData(getRuntimeContext().getMetricGroup());
Review Comment:
metricData can be replace by class of connector-base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5374: [INLONG-5205][Sort] Add reporting metrics for Elasticsearch 6 connector
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5374:
URL: https://github.com/apache/inlong/pull/5374#discussion_r941953778
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/ElasticsearchOptions.java:
##########
@@ -155,8 +144,23 @@ public enum BackOffType {
.withDescription(
"The format must produce a valid JSON document. "
+ "Please refer to the documentation on formats for more details.");
+ public static final ConfigOption<String> INLONG_METRIC =
Review Comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org