You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Ferdy Galema (JIRA)" <ji...@apache.org> on 2012/07/30 14:41:33 UTC
[jira] [Created] (NUTCH-1442) indexingfilter.order is property is
misread in code
Ferdy Galema created NUTCH-1442:
-----------------------------------
Summary: indexingfilter.order is property is misread in code
Key: NUTCH-1442
URL: https://issues.apache.org/jira/browse/NUTCH-1442
Project: Nutch
Issue Type: Bug
Reporter: Ferdy Galema
Fix For: 2.1
The property for indexfilters order is defined as indexingfilter.order in nutch-default, however the code in IndexingFilters tries to read it as indexingfilterhbase.order. Clearly this is an artifact from the past and should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1442) indexingfilter.order is property is
misread in code
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433955#comment-13433955 ]
Ferdy Galema commented on NUTCH-1442:
-------------------------------------
Thanks. Looks fine.
Assertions should not always be needed. (Sometimes running tests without throwing exceptions is fine enough). In this case, I'm not sure. The test justs indexes a single document. Also notice the statement in comments from Nutch trunk. That one should be removed at least. This can be addressed in another issue for improving the test.
> indexingfilter.order is property is misread in code
> ---------------------------------------------------
>
> Key: NUTCH-1442
> URL: https://issues.apache.org/jira/browse/NUTCH-1442
> Project: Nutch
> Issue Type: Bug
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Fix For: 2.1
>
> Attachments: NUTCH-1442.patch
>
>
> The property for indexfilters order is defined as indexingfilter.order in nutch-default, however the code in IndexingFilters tries to read it as indexingfilterhbase.order. Clearly this is an artifact from the past and should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NUTCH-1442) indexingfilter.order is property is
misread in code
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney resolved NUTCH-1442.
-----------------------------------------
Resolution: Fixed
Assignee: Lewis John McGibbney
Committed @revision 1372593 in 2.x head. It would be great if I we could also clarify the indexingfilters test query.
> indexingfilter.order is property is misread in code
> ---------------------------------------------------
>
> Key: NUTCH-1442
> URL: https://issues.apache.org/jira/browse/NUTCH-1442
> Project: Nutch
> Issue Type: Bug
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Fix For: 2.1
>
> Attachments: NUTCH-1442.patch
>
>
> The property for indexfilters order is defined as indexingfilter.order in nutch-default, however the code in IndexingFilters tries to read it as indexingfilterhbase.order. Clearly this is an artifact from the past and should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (NUTCH-1442) indexingfilter.order is property is
misread in code
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy Galema closed NUTCH-1442.
-------------------------------
> indexingfilter.order is property is misread in code
> ---------------------------------------------------
>
> Key: NUTCH-1442
> URL: https://issues.apache.org/jira/browse/NUTCH-1442
> Project: Nutch
> Issue Type: Bug
> Reporter: Ferdy Galema
> Assignee: Lewis John McGibbney
> Fix For: 2.1
>
> Attachments: NUTCH-1442.patch
>
>
> The property for indexfilters order is defined as indexingfilter.order in nutch-default, however the code in IndexingFilters tries to read it as indexingfilterhbase.order. Clearly this is an artifact from the past and should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1442) indexingfilter.order is property is
misread in code
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433368#comment-13433368 ]
Lewis John McGibbney commented on NUTCH-1442:
---------------------------------------------
I'm not sure about this. Looking at the test o.a.n.indexer.TestIndexingFilters it looks to me like nothing is actually being tested! There are no assertions.
Also I would like to add a test for the filter order... which we could add to the nutch-site.xml used for the testing.
Can someone confirm if the above is true or am I going off my head? Btw my views are the same about the test for trunk.
Thanks
> indexingfilter.order is property is misread in code
> ---------------------------------------------------
>
> Key: NUTCH-1442
> URL: https://issues.apache.org/jira/browse/NUTCH-1442
> Project: Nutch
> Issue Type: Bug
> Reporter: Ferdy Galema
> Fix For: 2.1
>
> Attachments: NUTCH-1442.patch
>
>
> The property for indexfilters order is defined as indexingfilter.order in nutch-default, however the code in IndexingFilters tries to read it as indexingfilterhbase.order. Clearly this is an artifact from the past and should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NUTCH-1442) indexingfilter.order is property is
misread in code
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lewis John McGibbney updated NUTCH-1442:
----------------------------------------
Attachment: NUTCH-1442.patch
trivial patch for 2.x head
> indexingfilter.order is property is misread in code
> ---------------------------------------------------
>
> Key: NUTCH-1442
> URL: https://issues.apache.org/jira/browse/NUTCH-1442
> Project: Nutch
> Issue Type: Bug
> Reporter: Ferdy Galema
> Fix For: 2.1
>
> Attachments: NUTCH-1442.patch
>
>
> The property for indexfilters order is defined as indexingfilter.order in nutch-default, however the code in IndexingFilters tries to read it as indexingfilterhbase.order. Clearly this is an artifact from the past and should be fixed asap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira