You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/14 11:32:56 UTC

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2113: [KYUUBI #2112] Improve the compatibility of queryTimeout in more version clients

ulysses-you commented on a change in pull request #2113:
URL: https://github.com/apache/incubator-kyuubi/pull/2113#discussion_r825850175



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -124,6 +124,11 @@ class ExecuteStatement(
           case CANCELED_STATE =>
             setState(OperationState.CANCELED)
 
+          case TIMEDOUT_STATE
+              if getSession.protocol.getValue <=
+                TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V8.getValue =>

Review comment:
       can we also add some comments to describe the reason why we do this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org