[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1735: remove lombok dependency in dao module

[GitBox <gi...@apache.org>]

Technoboy- commented on a change in pull request #1735: remove lombok dependency in dao module
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1735#discussion_r363321708
 
 

 ##########
 File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AccessToken.java
 ##########
 @@ -105,4 +103,45 @@ public Date getUpdateTime() {
     public void setUpdateTime(Date updateTime) {
         this.updateTime = updateTime;
     }
+
+    @Override
+    public boolean equals(Object o) {
 
 Review comment:
   Think about the real scenario ：
   Id of accessToken is generated by MySQL, so id is unique.  So what is the best implementation of equals method ？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services