You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Guosmilesmile (via GitHub)" <gi...@apache.org> on 2025/04/15 07:13:14 UTC
[PR] Flink: fix unlock when previous job orphaned lock [iceberg]
Guosmilesmile opened a new pull request, #12794:
URL: https://github.com/apache/iceberg/pull/12794
In the following scenario, the performance of TableMaintenance may not meet expectations:
1. The previous job stopped but left a lock that was not released.
2. A new job starts directly instead of recovering from state (when there is an existing lock, but no state).
3. TableMaintenance keeps failing to try to acquire the lock and cannot execute new tasks.
This PR aims to release the lock when the job starts without state to avoid the issue of failing to acquire the lock indefinitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: fix unlock when previous job orphaned lock [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #12794:
URL: https://github.com/apache/iceberg/pull/12794#discussion_r2043913177
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java:
##########
@@ -291,6 +291,24 @@ void testStateRestore() throws Exception {
}
}
+ @Test
+ void testNewJobReleasesPreviousJobHoldLock() throws Exception {
Review Comment:
nit: could we rename to `testNewJobReleasesExistingLock`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: fix unlock when previous job orphaned lock [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #12794:
URL: https://github.com/apache/iceberg/pull/12794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: fix unlock when previous job orphaned lock [iceberg]
Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #12794:
URL: https://github.com/apache/iceberg/pull/12794#discussion_r2043930599
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java:
##########
@@ -291,6 +291,24 @@ void testStateRestore() throws Exception {
}
}
+ @Test
+ void testNewJobReleasesPreviousJobHoldLock() throws Exception {
Review Comment:
yes , I have fix it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: Fix TriggerManager to unlock task execution when previous job left an orphaned lock [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #12794:
URL: https://github.com/apache/iceberg/pull/12794#issuecomment-2804814291
Merged to main.
Thanks for catching and fixing this @Guosmilesmile!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Flink: Fix TriggerManager to unlock task execution when previous job left an orphaned lock [iceberg]
Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on PR #12794:
URL: https://github.com/apache/iceberg/pull/12794#issuecomment-2804872192
@pvary Thanks for the review! I have create the backport in https://github.com/apache/iceberg/pull/12801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org