You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2023/03/08 12:41:59 UTC
svn commit: r1908197 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java
Author: tilman
Date: Wed Mar 8 12:41:59 2023
New Revision: 1908197
URL: http://svn.apache.org/viewvc?rev=1908197&view=rev
Log:
PDFBOX-4892: split long method, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java?rev=1908197&r1=1908196&r2=1908197&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/ContentStreamWriter.java Wed Mar 8 12:41:59 2023
@@ -112,6 +112,35 @@ public class ContentStreamWriter
}
}
+ private void writeObject(Operator op) throws IOException
+ {
+ if (op.getName().equals(OperatorName.BEGIN_INLINE_IMAGE))
+ {
+ output.write(OperatorName.BEGIN_INLINE_IMAGE.getBytes(StandardCharsets.ISO_8859_1));
+ output.write(EOL);
+ COSDictionary dic = op.getImageParameters();
+ for (COSName key : dic.keySet())
+ {
+ Object value = dic.getDictionaryObject(key);
+ key.writePDF(output);
+ output.write(SPACE);
+ writeObject(value);
+ output.write(EOL);
+ }
+ output.write(OperatorName.BEGIN_INLINE_IMAGE_DATA.getBytes(StandardCharsets.ISO_8859_1));
+ output.write(EOL);
+ output.write(op.getImageData());
+ output.write(EOL);
+ output.write(OperatorName.END_INLINE_IMAGE.getBytes(StandardCharsets.ISO_8859_1));
+ output.write(EOL);
+ }
+ else
+ {
+ output.write(op.getName().getBytes(StandardCharsets.ISO_8859_1));
+ output.write(EOL);
+ }
+ }
+
private void writeObject( Object o ) throws IOException
{
if( o instanceof COSString )
@@ -167,32 +196,7 @@ public class ContentStreamWriter
}
else if( o instanceof Operator)
{
- Operator op = (Operator)o;
- if( op.getName().equals( OperatorName.BEGIN_INLINE_IMAGE ) )
- {
- output.write( OperatorName.BEGIN_INLINE_IMAGE.getBytes(StandardCharsets.ISO_8859_1) );
- output.write(EOL);
- COSDictionary dic = op.getImageParameters();
- for( COSName key : dic.keySet() )
- {
- Object value = dic.getDictionaryObject( key );
- key.writePDF( output );
- output.write( SPACE );
- writeObject( value );
- output.write( EOL );
- }
- output.write( OperatorName.BEGIN_INLINE_IMAGE_DATA.getBytes(StandardCharsets.ISO_8859_1) );
- output.write( EOL );
- output.write( op.getImageData() );
- output.write( EOL );
- output.write( OperatorName.END_INLINE_IMAGE.getBytes(StandardCharsets.ISO_8859_1) );
- output.write( EOL );
- }
- else
- {
- output.write( op.getName().getBytes(StandardCharsets.ISO_8859_1) );
- output.write( EOL );
- }
+ writeObject((Operator) o);
}
else if (o instanceof COSNull)
{