You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/05/20 00:09:40 UTC
[jira] [Created] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Jonathan Ellis created CASSANDRA-4262:
-----------------------------------------
Summary: 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
Key: CASSANDRA-4262
URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0
Reporter: Jonathan Ellis
Priority: Critical
Fix For: 1.1.1
1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne reassigned CASSANDRA-4262:
-------------------------------------------
Assignee: Sylvain Lebresne
> 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-4262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 1.1.1
>
>
> 1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4262:
----------------------------------------
Attachment: 4262-v2.txt
Actually, I'm wrong. We do allow seq-scan-with-filters on the thrift side. So anyway, attaching a v2 that does throw an exception in that case on the sending node.
Still leave the question if we should allow those sequential queries with filters in CQL3 I guess.
> 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-4262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: 4262-v2.txt, 4262.txt
>
>
> 1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4262:
----------------------------------------
Attachment: 4262.txt
Attached patch to generate IndexScanCommand message when appropriate.
I've pushed a test in dtests too (in rolling_upgrade_test.py). Fails before the patch, works after.
> 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-4262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: 4262.txt
>
>
> 1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287470#comment-13287470 ]
Jonathan Ellis commented on CASSANDRA-4262:
-------------------------------------------
Can we do something to make the problem more obvious when someone does a seq-scan-with-filters in a mixed-version cluster, than just send the RSC and have it error out? Even just logging WARN would be better than nothing.
> 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-4262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: 4262.txt
>
>
> 1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287498#comment-13287498 ]
Jonathan Ellis commented on CASSANDRA-4262:
-------------------------------------------
+1
Ultimately I'd like to have a CqlInputFormat for Hadoop, which is why we opened that up on the Thrift side.
> 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-4262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: 4262-v2.txt, 4262.txt
>
>
> 1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4262) 1.1 does not preserve
compatibility w/ index queries against 1.0 nodes
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287480#comment-13287480 ]
Sylvain Lebresne commented on CASSANDRA-4262:
---------------------------------------------
Actually, I think we don't allow at all seq-scan-with-filters (even the storage engine can do it). The reason it's not allowed we haven't changed the validation of index expression, so that an invalid request will be return upfront to the user saying no columns are indexed. This is also true of CQL3.
On the front of "should we allow those seq-scan-with-filters", that would be a case of seemingly simple queries that could take *a lot* of time (I suppose you could do that with 2ndary indexes too, but you have to try a little bit more harder), so maybe this is worth giving it a though?
> 1.1 does not preserve compatibility w/ index queries against 1.0 nodes
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-4262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: 4262.txt
>
>
> 1.1 merged index + seq scan paths into RangeSliceCommand. 1.1 StorageProxy always sends a RSC for either scan type. But 1.0 RSVH only does seq scans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira