You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/08/17 01:22:58 UTC
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14086
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
[compression] Refactor unit tests and add simple benchmark test
Refactor unit tests of compression-test to reduce redundant code,
and also add simple benchmark tests for compression and uncompression
to check whether an upgrade of a thirdparty compression library
influence efficiency.
Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
---
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/compression/compression_codec.cc
M src/kudu/util/compression/compression_codec.h
3 files changed, 127 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/14086/1
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 5: Verified+1
unrelated flake in MultiThreadedTabletTest/3.DeleteAndReinsert
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 03:22:27 +0000
Gerrit-HasComments: No
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14086
to look at the new patch set (#2).
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
[compression] Refactor unit tests and add simple benchmark test
Refactor unit tests of compression-test to reduce redundant code,
and also add simple benchmark tests for compression and uncompression
to check whether an upgrade of a thirdparty compression library
influences efficiency.
Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
---
M src/kudu/util/compression/compression-test.cc
1 file changed, 85 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/14086/2
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
[compression] Refactor unit tests and add simple benchmark test
Refactor unit tests of compression-test to reduce redundant code,
and also add simple benchmark tests for compression and uncompression
to check whether an upgrade of a thirdparty compression library
influences efficiency.
Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Reviewed-on: http://gerrit.cloudera.org:8080/14086
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/compression/compression-test.cc
1 file changed, 84 insertions(+), 13 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/14086/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14086/1//COMMIT_MSG@12
PS1, Line 12: influence
Nit: influences
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc
File src/kudu/util/compression/compression-test.cc:
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@45
PS1, Line 45: void TestCompressionCodec() {
Since the test fixture is stateless, there's no value gained by defining TestCompressionCodec and Benchmark as fixture methods vs. just putting the logic directly in the tests themselves.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@88
PS1, Line 88: char materials[kMaterialCount][kInputSize];
Heap allocate this so that the thread stack isn't blown out if someone customizes kMaterialCount or kInputSize.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@89
PS1, Line 89: Random r(0); // Use seed '0' means generate the same data for all compression algorithms.
This suggests that perhaps the benchmark should be structured as a single test with a loop over the different compression types. That way you could use SeedRandom() here and actually get useful variety amongst the different invocations of the benchmark.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@98
PS1, Line 98: r.Next() % kMaterialCount
Random::Uniform() is more clear for this.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@123
PS1, Line 123: LOG(INFO) << GetCompressionCodecName(compression) << " compress throughput: "
Here and in Execute Uncompress consider using LOG_TIMING(), a useful macro that handles the stopwatch stuff for you.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression_codec.h
File src/kudu/util/compression/compression_codec.h:
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression_codec.h@77
PS1, Line 77: // Returns the compression codec name given the type
: std::string GetCompressionCodecName(CompressionType type);
Could you get by with CompressionType_Name? It's auto-generated by protoc: https://developers.google.com/protocol-buffers/docs/reference/cpp-generated#enum
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Aug 2019 04:20:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 4:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/14086/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14086/1//COMMIT_MSG@12
PS1, Line 12: influence
> Nit: influences
Done
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc
File src/kudu/util/compression/compression-test.cc:
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@45
PS1, Line 45:
> Since the test fixture is stateless, there's no value gained by defining Te
Done
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@88
PS1, Line 88: for (int i = 0; i < kMaterialCount; ++i) {
> Heap allocate this so that the thread stack isn't blown out if someone cust
Done
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@89
PS1, Line 89: materials.emplace_back(RandomString(kInputSize, &random));
> This suggests that perhaps the benchmark should be structured as a single t
Done
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@98
PS1, Line 98:
> Random::Uniform() is more clear for this.
Done
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@123
PS1, Line 123: }
> Here and in Execute Uncompress consider using LOG_TIMING(), a useful macro
I saw implemention of LOG_TIMING, but the internal stopwatch couldn't be exposed, so we can't calculate thoughput if not declare another stopwatch outside.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression_codec.h
File src/kudu/util/compression/compression_codec.h:
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression_codec.h@77
PS1, Line 77: } // namespace kudu
: #endif
> Could you get by with CompressionType_Name? It's auto-generated by protoc:
Done
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Mon, 19 Aug 2019 15:29:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc
File src/kudu/util/compression/compression-test.cc:
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@120
PS4, Line 120: total_len >> 20
> On my platform, Intel Xeon E5-2620 v3, CentOS 7.3.1611, benchmark output:
Ah, great -- thank you for the information on the benchmark results.
Yes, the essential point here is that the throughput is in order of hundreds of {K,M}Bytes/sec, so the rounding would not hide any improvement north of 1%.
In other words, if the result numbers of {K,M}B/sec were low, rounding them down might hide performance improvement. E.g., if the test were run just for 1 second, then rounding down 19455 bytes to 18 Kbytes with the new implementation would result in 'hidden' almost 5% improvement assuming the decompression rate of prior implementation was 18432 bytes/sec.
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@136
PS4, Line 136: total_len >> 20
> The same.
Good catch: yep, it's expected the decompression ratio should be higher than the compression ratio for those algos :)
At least, now result for LZ4 looks closer to the benchmark table at https://github.com/lz4/lz4
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 03:22:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc
File src/kudu/util/compression/compression-test.cc:
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@81
PS4, Line 81: const int kMaterialCount = 16;
: const int kInputSize = 8;
: const int kSliceCount = 1024;
nit:
use 'const consexpr' for the constants?
https://en.cppreference.com/w/cpp/language/constexpr
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@120
PS4, Line 120: total_len >> 20
I'm curious whether this up-to-MB rounding might hide performance boost from switching to the newer version of the lz4 library?
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@136
PS4, Line 136: total_len >> 10
ditto
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Mon, 19 Aug 2019 16:59:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc
File src/kudu/util/compression/compression-test.cc:
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@81
PS4, Line 81: const int kMaterialCount = 16;
: const int kInputSize = 8;
: const int kSliceCount = 1024;
> nit:
Done
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@120
PS4, Line 120: total_len >> 20
> I'm curious whether this up-to-MB rounding might hide performance boost fr
On my platform, Intel Xeon E5-2620 v3, CentOS 7.3.1611, benchmark output:
I0820 10:06:46.046753 92829 compression-test.cc:121] SNAPPY compress throughput: 254.361 MB/sec, ratio: 0.256226
I0820 10:06:49.046949 92829 compression-test.cc:137] SNAPPY uncompress throughput: 1346.23 KB/sec
I0820 10:06:52.047041 92829 compression-test.cc:121] LZ4 compress throughput: 415.709 MB/sec, ratio: 0.364502
I0820 10:06:55.047103 92829 compression-test.cc:137] LZ4 uncompress throughput: 1955 KB/sec
I0820 10:06:58.047474 92829 compression-test.cc:121] ZLIB compress throughput: 18.6865 MB/sec, ratio: 0.150879
I0820 10:07:01.047546 92829 compression-test.cc:137] ZLIB uncompress throughput: 94.2997 KB/sec
Thoughtput of new LZ4 is about 415.709 MB/sec, since it's a double type and value is several hundreds, performance improvment will not hide much.
http://gerrit.cloudera.org:8080/#/c/14086/4/src/kudu/util/compression/compression-test.cc@136
PS4, Line 136: total_len >> 10
> ditto
The same.
And you remind me to reconsider uncompression calculate method.
Now, output looks like:
I0820 10:36:41.497403 81986 compression-test.cc:121] SNAPPY compress throughput: 256.966 MB/sec, ratio: 0.257446
I0820 10:36:44.497658 81986 compression-test.cc:137] SNAPPY uncompress throughput: 1350.52 MB/sec
I0820 10:36:47.497826 81986 compression-test.cc:121] LZ4 compress throughput: 415.471 MB/sec, ratio: 0.366089
I0820 10:36:50.497938 81986 compression-test.cc:137] LZ4 uncompress throughput: 1958.92 MB/sec
I0820 10:36:53.498111 81986 compression-test.cc:121] ZLIB compress throughput: 18.3828 MB/sec, ratio: 0.149536
I0820 10:36:56.498231 81986 compression-test.cc:137] ZLIB uncompress throughput: 94.4513 MB/sec
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 20 Aug 2019 02:40:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14086
to look at the new patch set (#3).
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
[compression] Refactor unit tests and add simple benchmark test
Refactor unit tests of compression-test to reduce redundant code,
and also add simple benchmark tests for compression and uncompression
to check whether an upgrade of a thirdparty compression library
influences efficiency.
Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
---
M src/kudu/util/compression/compression-test.cc
1 file changed, 83 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/14086/3
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14086
to look at the new patch set (#5).
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
[compression] Refactor unit tests and add simple benchmark test
Refactor unit tests of compression-test to reduce redundant code,
and also add simple benchmark tests for compression and uncompression
to check whether an upgrade of a thirdparty compression library
influences efficiency.
Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
---
M src/kudu/util/compression/compression-test.cc
1 file changed, 84 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/14086/5
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14086
to look at the new patch set (#4).
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
[compression] Refactor unit tests and add simple benchmark test
Refactor unit tests of compression-test to reduce redundant code,
and also add simple benchmark tests for compression and uncompression
to check whether an upgrade of a thirdparty compression library
influences efficiency.
Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
---
M src/kudu/util/compression/compression-test.cc
1 file changed, 83 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/14086/4
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [compression] Refactor unit tests and add simple benchmark test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14086 )
Change subject: [compression] Refactor unit tests and add simple benchmark test
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Will defer to Alexey.
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc
File src/kudu/util/compression/compression-test.cc:
http://gerrit.cloudera.org:8080/#/c/14086/1/src/kudu/util/compression/compression-test.cc@123
PS1, Line 123: }
> I saw implemention of LOG_TIMING, but the internal stopwatch couldn't be ex
Fair point.
--
To view, visit http://gerrit.cloudera.org:8080/14086
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If09817d223b98c825d0c8276c8f663b5c5b9eb12
Gerrit-Change-Number: 14086
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Mon, 19 Aug 2019 18:54:52 +0000
Gerrit-HasComments: Yes