You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 01:21:15 UTC
[GitHub] [flink] Jiayi-Liao opened a new pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Jiayi-Liao opened a new pull request #12307:
URL: https://github.com/apache/flink/pull/12307
## What is the purpose of the change
Rebased on https://github.com/apache/flink/pull/12304, This change contains two commits:
1. Remove deprecated enable default background cleanup
2. Remove deprecated option and method to disable TTL compaction filter
## Brief change log
* Remove deprecated cleanupInBackground in StateTtlConfig.
* remove `enableTtlCompactionFilter` and related deprecated API in `RocksDBStateBackend`, `RocksDBKeyedStateBackend` and `CompactionFiltersManager`
* remove `TTL_COMPACT_FILTER_ENABLED` in `RocksDBOptions`
* remove compaction_filter related deprecated API in python
## Verifying this change
Existing unit testing should be able to cover this change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: remove deprecated API
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
}, {
"hash" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099",
"triggerID" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a353b26e154ac85af664bbac5a1cfdd95286ab8b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb1d2c95b86181db107ce557a4fe43da4d217f31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633333274
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit aa505a4220a4c1910bb447cb60f36ea2201bd9fb (Fri Oct 16 10:55:30 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb1d2c95b86181db107ce557a4fe43da4d217f31 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Jiayi-Liao commented on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
Jiayi-Liao commented on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633379241
The latest failure seems to be an unused import in flink-python(I can't install flink-python locally by following README.md in flink-python package because there seems to be something wrong with my local python environment).
So... kindly ask @flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
}, {
"hash" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099",
"triggerID" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"triggerType" : "PUSH"
}, {
"hash" : "1414be06762d3238c4138d9fab4daf26f661f58d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2104",
"triggerID" : "1414be06762d3238c4138d9fab4daf26f661f58d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1414be06762d3238c4138d9fab4daf26f661f58d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2104)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
}, {
"hash" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb1d2c95b86181db107ce557a4fe43da4d217f31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088)
* a353b26e154ac85af664bbac5a1cfdd95286ab8b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
}, {
"hash" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099",
"triggerID" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb1d2c95b86181db107ce557a4fe43da4d217f31 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088)
* a353b26e154ac85af664bbac5a1cfdd95286ab8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
}, {
"hash" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099",
"triggerID" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"triggerType" : "PUSH"
}, {
"hash" : "1414be06762d3238c4138d9fab4daf26f661f58d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1414be06762d3238c4138d9fab4daf26f661f58d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a353b26e154ac85af664bbac5a1cfdd95286ab8b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099)
* 1414be06762d3238c4138d9fab4daf26f661f58d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633333274
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bb1d2c95b86181db107ce557a4fe43da4d217f31 (Mon May 25 01:23:33 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15621).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin closed pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #12307:
URL: https://github.com/apache/flink/pull/12307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb1d2c95b86181db107ce557a4fe43da4d217f31 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12307: [FLINK-15621] Remove deprecated option and method to disable TTL compaction filter
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12307:
URL: https://github.com/apache/flink/pull/12307#issuecomment-633334512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2088",
"triggerID" : "bb1d2c95b86181db107ce557a4fe43da4d217f31",
"triggerType" : "PUSH"
}, {
"hash" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099",
"triggerID" : "a353b26e154ac85af664bbac5a1cfdd95286ab8b",
"triggerType" : "PUSH"
}, {
"hash" : "1414be06762d3238c4138d9fab4daf26f661f58d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2104",
"triggerID" : "1414be06762d3238c4138d9fab4daf26f661f58d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a353b26e154ac85af664bbac5a1cfdd95286ab8b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2099)
* 1414be06762d3238c4138d9fab4daf26f661f58d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2104)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org