You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/05 02:28:54 UTC

[GitHub] [rocketmq] cserwen commented on pull request #4224: [ISSUE #4223]Delete repeated calls in MQClientInstance#start

cserwen commented on PR #4224:
URL: https://github.com/apache/rocketmq/pull/4224#issuecomment-1118106570

   > > DefaultMQPushConsumerImpl.java
   > 
   > > It will be used to send retry messages if exception happens.
   > > https://github.com/apache/rocketmq/blob/df3f8de4c03a282de052b130ae368ab00faca039/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L512
   > > 
   > > ![image](https://user-images.githubusercontent.com/46882838/165924585-a98b5be4-c9a1-45f2-b7e7-9e5f1d0e41a6.png)
   > 
   > It's not like we're talking about the same problem, you can review my code.
   
   Yes, I have reviewed your code before. IMO,the consumer may not work normally if you remove it. Besides, It only brings an extra heartbeat and does not add a new scheduled task. 
   ![image](https://user-images.githubusercontent.com/46882838/166855584-ff2e941f-8664-49b4-a4d4-00634702552f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org