[jira] Commented: (MECLIPSE-173) Project should be considered a Java project if it has at least one source folder even if the language of its artifact handler is not java

["Graham Leggett (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103921 ] 

Graham Leggett commented on MECLIPSE-173:
-----------------------------------------

The v2.4 plugin contains a patch that forced the project to be considered a Java project if the PDE mode was enabled.

This in theory should solve this problem.


> Project should be considered a Java project if it has at least one source folder even if the language of its artifact handler is not java
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-173
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-173
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: PDE support
>    Affects Versions: 2.2
>            Reporter: Cédric Vidal
>             Fix For: 2.5
>
>         Attachments: MECLIPSE-173.patch
>
>
> Use case:
> - I have non java source files in src/main/foo (for example a UML model)
> - the "foo" artifact handler builds a zip containing the "foo" source files and its language is not "java" (for example the UML model zipped)
> - I have a "bar" plugin which generates "bar" java source files from the "foo" source files in target/generated-sources/bar. (for example an MDA plugin)
> - The "bar" plugin also builds a jar containing the target/generated-sources/bar java source files and attachs it with a "bar" classifier.
> So even if the language of my project's artifact handler is not set to "java", since my project contains java source code (generated), my project should be considered a java project so that it can be referenced in multiproject mode by other projects in their build path.
> The effect is obtained by replacing :
>         isJavaProject = "java".equals( artifactHandler.getLanguage() ) && !"ear".equals( packaging );
> by
>         isJavaProject = ("java".equals(artifactHandler.getLanguage()) || sourceDirs.length > 0)
> 				&& !"ear".equals(packaging);
> and moving the code which builds the sourceDirs from the EclipsePlugin#writeConfiguration( IdeDependency[] deps ) to the EclipsePlugin#setup() method.
> Regards,
> Cédric

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira