[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14407: Update imagenet quantization script for MKL-DNN

[GitBox <gi...@apache.org>]

ciyongch commented on a change in pull request #14407: Update imagenet quantization script for MKL-DNN
URL: https://github.com/apache/incubator-mxnet/pull/14407#discussion_r264971022
 
 

 ##########
 File path: example/quantization/imagenet_gen_qsym_mkldnn.py
 ##########
 @@ -208,13 +208,15 @@ def save_params(fname, arg_params, aux_params, logger=None):
     if args.model == 'imagenet1k-resnet-152':
         rgb_mean = '0,0,0'
         rgb_std = '1,1,1'
-        excluded_sym_names += ['flatten0']
+        # TODO, fc1 will be enabled after MKL-DNN 0.18
+        excluded_sym_names += ['flatten0', 'fc1']
         if exclude_first_conv:
             excluded_sym_names += ['conv0']
     elif args.model == 'imagenet1k-inception-bn':
         rgb_mean = '123.68,116.779,103.939'
         rgb_std = '1,1,1'
-        excluded_sym_names += ['flatten']
+        # TODO, fc1 will be enabled after MKL-DNN 0.18
 
 Review comment:
   For now, these three examples will fail due to limitation of quantized FullyConnected (as it's enabled in current script). 
   If v0.18 will be merged into master in a short time, then this would be fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services