You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/22 20:52:22 UTC
[GitHub] [ignite] Nikita-tech-writer opened a new pull request #8690: IGNITE-13606
Nikita-tech-writer opened a new pull request #8690:
URL: https://github.com/apache/ignite/pull/8690
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda commented on a change in pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
dmagda commented on a change in pull request #8690:
URL: https://github.com/apache/ignite/pull/8690#discussion_r562920446
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -24,6 +24,23 @@ You can also access them programmatically.
On this page, we've collected the most useful metrics and grouped them into various common categories based on the monitoring task.
+[NOTE]
Review comment:
How about having this as a chapter? That's an essential configuration step you can't miss.
== Enabling JMX for Ignite
{the content you have}
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -24,6 +24,23 @@ You can also access them programmatically.
On this page, we've collected the most useful metrics and grouped them into various common categories based on the monitoring task.
+[NOTE]
+====
+By default, the JMX automatic configuration is disabled.
+To enable it, configure the following environment variables:
+
+* For `control.sh`, configure the `CONTROL_JVM_OPTS` variable
+* For `ignite.sh`, configure the `JVM_OPTS` variable
+
+For example:
+[source,shell]
+----
+JVM_OPTS="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=${JMX_PORT} \
Review comment:
Have a complete instruction for both Unix and Windows. For instance, "ignite.sh ... parameters"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda merged pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
dmagda merged pull request #8690:
URL: https://github.com/apache/ignite/pull/8690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8690:
URL: https://github.com/apache/ignite/pull/8690#discussion_r564083589
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -24,6 +24,23 @@ You can also access them programmatically.
On this page, we've collected the most useful metrics and grouped them into various common categories based on the monitoring task.
+[NOTE]
+====
+By default, the JMX automatic configuration is disabled.
+To enable it, configure the following environment variables:
+
+* For `control.sh`, configure the `CONTROL_JVM_OPTS` variable
+* For `ignite.sh`, configure the `JVM_OPTS` variable
+
+For example:
+[source,shell]
+----
+JVM_OPTS="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=${JMX_PORT} \
Review comment:
Not sure whether it's necessary to add separate tabs for the environment variable configuration.
As for the CONTROL_JVM_OPTS variable, its configuration depends on the Java version, so we can't provide a universal example here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] dmagda merged pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
dmagda merged pull request #8690:
URL: https://github.com/apache/ignite/pull/8690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8690:
URL: https://github.com/apache/ignite/pull/8690#discussion_r564069455
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -24,6 +24,23 @@ You can also access them programmatically.
On this page, we've collected the most useful metrics and grouped them into various common categories based on the monitoring task.
+[NOTE]
+====
+By default, the JMX automatic configuration is disabled.
+To enable it, configure the following environment variables:
+
+* For `control.sh`, configure the `CONTROL_JVM_OPTS` variable
+* For `ignite.sh`, configure the `JVM_OPTS` variable
+
+For example:
+[source,shell]
+----
+JVM_OPTS="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=${JMX_PORT} \
Review comment:
Not sure whether it's necessary to add separate tabs for the environment variable configuration (I'm pretty sure that it does not depend on the OS type).
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -24,6 +24,23 @@ You can also access them programmatically.
On this page, we've collected the most useful metrics and grouped them into various common categories based on the monitoring task.
+[NOTE]
+====
+By default, the JMX automatic configuration is disabled.
+To enable it, configure the following environment variables:
+
+* For `control.sh`, configure the `CONTROL_JVM_OPTS` variable
+* For `ignite.sh`, configure the `JVM_OPTS` variable
+
+For example:
+[source,shell]
+----
+JVM_OPTS="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=${JMX_PORT} \
Review comment:
Not sure whether it's necessary to add separate tabs for the environment variable configuration.
As for the CONTROL_JVM_OPTS variable, its configuration depends on the Java version, so we can't provide a universal example here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #8690:
URL: https://github.com/apache/ignite/pull/8690#issuecomment-767746587
@Mmuzaf could you please cherry-pick this to 2.10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #8690: IGNITE-13606
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #8690:
URL: https://github.com/apache/ignite/pull/8690#discussion_r564069455
##########
File path: docs/_docs/monitoring-metrics/metrics.adoc
##########
@@ -24,6 +24,23 @@ You can also access them programmatically.
On this page, we've collected the most useful metrics and grouped them into various common categories based on the monitoring task.
+[NOTE]
+====
+By default, the JMX automatic configuration is disabled.
+To enable it, configure the following environment variables:
+
+* For `control.sh`, configure the `CONTROL_JVM_OPTS` variable
+* For `ignite.sh`, configure the `JVM_OPTS` variable
+
+For example:
+[source,shell]
+----
+JVM_OPTS="-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=${JMX_PORT} \
Review comment:
Not sure whether it's necessary to add separate tabs for the environment variable configuration (I'm pretty sure that it does not depend on the OS type).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org