You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/03/28 19:49:46 UTC
[kudu-CR] design docs: Fix bad markdown formatting in tablet.md
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6500
Change subject: design docs: Fix bad markdown formatting in tablet.md
......................................................................
design docs: Fix bad markdown formatting in tablet.md
Level 1 headings are only allowed to have a line of equals signs under
the text of the heading, not before.
Change-Id: I336b7a5814da30812e5dd77289027ac296fcd2da
---
M docs/design-docs/tablet.md
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/6500/1
--
To view, visit http://gerrit.cloudera.org:8080/6500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I336b7a5814da30812e5dd77289027ac296fcd2da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] design docs: Fix bad markdown formatting in tablet.md
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: design docs: Fix bad markdown formatting in tablet.md
......................................................................
Patch Set 3:
Thanks, let's just fix this here for now
--
To view, visit http://gerrit.cloudera.org:8080/6500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I336b7a5814da30812e5dd77289027ac296fcd2da
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] design docs: Fix bad markdown formatting in tablet.md
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: design docs: Fix bad markdown formatting in tablet.md
......................................................................
design docs: Fix bad markdown formatting in tablet.md
Level 1 headings are only allowed to have a line of equals signs under
the text of the heading, not before.
Change-Id: I336b7a5814da30812e5dd77289027ac296fcd2da
Reviewed-on: http://gerrit.cloudera.org:8080/6500
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M docs/design-docs/tablet.md
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I336b7a5814da30812e5dd77289027ac296fcd2da
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] design docs: Fix bad markdown formatting in tablet.md
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: design docs: Fix bad markdown formatting in tablet.md
......................................................................
Patch Set 2: Code-Review+2
The same peccadillo exists in other design docs, e.g. codegen.md and master.md. You can fix those if you want or just merge this.
--
To view, visit http://gerrit.cloudera.org:8080/6500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I336b7a5814da30812e5dd77289027ac296fcd2da
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No