You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jason Dillon (JIRA)" <de...@geronimo.apache.org> on 2006/07/24 23:56:13 UTC
[jira] Created: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
-------------------------------------------------------------------------
Key: GERONIMO-2225
URL: http://issues.apache.org/jira/browse/GERONIMO-2225
Project: Geronimo
Issue Type: Sub-task
Security Level: public (Regular issues)
Components: buildsystem
Affects Versions: 1.2
Reporter: Jason Dillon
Assigned To: Jason Dillon
Priority: Blocker
Fix For: 1.2
The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423320 ]
Anita Kulshreshtha commented on GERONIMO-2225:
----------------------------------------------
When the deployer is invoked (please see PackageBuilder.invokeDeployer(..) using a filename it creates a zipped artifact (.car) in target/repository. If it is invoked with null it leaves the generated artifacts unpacked at target/repository/o/a/g/artifactId.
The daytrader config generates 3 artifacts. These are installed using the attached artifact feature of Maven 2. The <multipleArtifact> is used for daytrader. The deployer gives error if target/repository/o/a/g/artifactId exists. Hence geronimo-plugin.xml must be filtered after the deployer has finished its work.
I have been using geronimo_groupId (see etc.patch and configs.patch) in the plans when there was an incompatibility issue. We should create geronimo-plugin.xml files for M2 in src/conf2.
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423234 ]
Jason Dillon commented on GERONIMO-2225:
----------------------------------------
FYI... there are also issues that the geronimo-plugin.xml for m1 is not compatible with the version needed for m2. :-(
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423174 ]
Anita Kulshreshtha commented on GERONIMO-2225:
----------------------------------------------
Jason, the applications configs (GERONIMO-2206) are probably not working because you did not include the code from m2-plugins.patch dt 10/July/06 attached to Geronimo-2067. It is not enough to just add <geronimoPlugin> to the configuration in pom.xml. The code to handle geronimoPlugin, i.e. to package geronmimo-plugin.xml is in these 4 files:
1. AbstractPackagingMojo.java
2. PackageBuilder.java
3. PlanProcessorMojo.java
4. PackageBuilderShellMojo.java
This code also provides a way to handle multiple artifacts generated during packaging of the daytrader configurations. BTW, you can omit the print statements ;-).
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423173 ]
Aaron Mulder commented on GERONIMO-2225:
----------------------------------------
Here's the diagnosis procedure:
{noformat}
> ls configs/welcome-jetty/src/conf/
geronimo-plugin.xml
> jar -tf configs/welcome-jetty/target/welcome-jetty-1.2-SNAPSHOT.car
META-INF/config.ser
META-INF/config.ser.sha1
META-INF/config.info
META-INF/MANIFEST.MF
geronimo-power.gif
geronimo-logo.png
main.css
images/head_bgstretch_1x86.gif
images/welcome_head_570x86.gif
images/powered_by_100x30.gif
index.jsp
WEB-INF/lib/geronimo-welcome-1.2-SNAPSHOT.jar
WEB-INF/web.xml
sampleNotInstalled.jsp
> jar -tf ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car
META-INF/config.ser
META-INF/config.ser.sha1
META-INF/config.info
META-INF/MANIFEST.MF
META-INF/geronimo-plugin.xml
geronimo-power.gif
geronimo-logo.png
main.css
images/head_bgstretch_1x86.gif
images/welcome_head_570x86.gif
images/powered_by_100x30.gif
index.jsp
WEB-INF/lib/jstl-1.1.1.jar
WEB-INF/lib/classes.jar
WEB-INF/lib/standard-1.1.1.jar
WEB-INF/web.xml
sampleNotInstalled.jsp
{noformat}
If you look at the plugin metadata file, it starts with:
{code:xml}
<?xml version="1.0" encoding="UTF-8"?>
<geronimo-plugin xmlns="http://geronimo.apache.org/xml/ns/plugins-1.1">
<name>Geronimo Welcome Web App (Jetty)</name>
<module-id>${pom.groupId}/${pom.artifactId}/${pom.currentVersion}/car</module-id>
<category>Core Geronimo</category>
...
{code}
So it needs variable substitution on the group/artifact/version/type.
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423354 ]
Aaron Mulder commented on GERONIMO-2225:
----------------------------------------
Anita, I didn't understand the bulk of your last comment. What are the 3 artifacts generated by the daytrader config? Does the Maven car plugin process the geronimo-plugin.xml "at the right moment" or do we attach some Ant script to one of the build stages to do the copy and filtering or what?
Jason, what part of geronimo-plugin.xml needs to change? Is it just the substitution variables? If so, if you tell me what the correct variable names should be then I'll change all the geronimo-plugin.xml files in the branch.
Anita, it sounds like you're saying we should have src/conf/geronimo-plugin.xml (M1) and src/conf2/geronimo-plugin.xml (M2). I don't think that's necessary. Let's just switch the plugin files to M2 in place. It will mean we don't generate working plugins for the M1 build, but that's OK, when we merge the branch back to trunk we'll be committed to M2 and I don't think we need to be able to generate plugins both ways (we're certainly not going to post 2 sets of plugins to the repository, one built with M1 and one build with M2).
If there was strong opposition to the plugins-for-M2-only approach I could just hardcode all the values for now and put back the variables after M1 has gone away, but that seems pretty silly.
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423231 ]
Jason Dillon commented on GERONIMO-2225:
----------------------------------------
I don't understand what is going on for the multiple artifact stuff...
Can you please explain what the use-case is? And what this is code is intending to do?
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=all ]
Jason Dillon closed GERONIMO-2225.
----------------------------------
Resolution: Fixed
This is fixed
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2225) The M2 build no longer inserts
META-INF/geronimo-plugin.xml into the CARs
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423366 ]
Anita Kulshreshtha commented on GERONIMO-2225:
----------------------------------------------
Aaron, the deployer will create 3 unpacked car (let me use dt for daytrader)for daytrader configuration:
1. target/repository/o/a/g/configs/dt/1.2-SNAPSHOT/dt-1.2-SNAPSHOT.car
2. target/repository/o/a/g/configs/dt-streamer.jar/1.2-SNAPSHOT/dt-streamer.jar-1.2-SNAPSHOT.car
3. target/repository/o/a/g/configs/dt-wsapplcient.jar/1.2-SNAPSHOT/dt-wsappclient.jar-1.2-SNAPSHOT.car
Yes, the plugin processes geronimo-plugin.xml at the right moment i.e. after these cars have been created
The variable substitution is taken care of by the plugin. Since we use different groupId for geronimo (o.a.g) in M2 the
geronimo-plugin.xml files need to be modifies. Since you have agreed that it is ok to have the plugins that do not work for
M1 build, src/conf2 is not necessary. At the time of merge (or before) we need to change the groupId
geronimo to org.apache.geronimo , and
ejb to org.openejb (not sure if this is used)
in all geronimo-plugin.xml files.
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
> Key: GERONIMO-2225
> URL: http://issues.apache.org/jira/browse/GERONIMO-2225
> Project: Geronimo
> Issue Type: Sub-task
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 1.2
> Reporter: Jason Dillon
> Assigned To: Jason Dillon
> Priority: Blocker
> Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml. There was handling for this in the M1 build (e.g. for the welcome app and other examples).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira