[jira] Closed: (SHINDIG-247) Refactor AbstractContentCache

["Kevin Brown (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown closed SHINDIG-247.
-------------------------------

    Resolution: Fixed

It looks like everything here has been applied in one form or another.

> Refactor AbstractContentCache
> -----------------------------
>
>                 Key: SHINDIG-247
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-247
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: Henning Schmiedehausen
>         Attachments: contentcache.patch
>
>
> The attached patch refactors the code from the AbstractContentCache class a bit:
> - add javadocs to AbstractContentCache and ContentCache
> - turn checkContent() into RemoteContent methods:
>       - isExpired() whether this RemoteContent object is expired
>       - isCacheable() whether this RemoteContent object can be cached
>       - updateExpires() modify the headers of the RemoteContent object to contain a valid expires header
> - This removes lots of functionality that is not really part of the ContentCache from AbstractContentCache and
>    turns canCache(RemoteContentRequest rcr) and canCache(RemoteContent rc) into very readable code

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.