You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/28 15:27:52 UTC

[GitHub] [maven-ejb-plugin] elharo commented on a change in pull request #11: [MEJB-130] Accept ejbVersion 4.x

elharo commented on a change in pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#discussion_r549387107



##########
File path: src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java
##########
@@ -465,10 +465,10 @@ private File generateEjbClient()
     private void checkEJBVersionCompliance( File deploymentDescriptor )
         throws MojoExecutionException
     {
-        if ( !ejbVersion.matches( "\\A[2-3]\\.[0-9]\\z" ) )
+        if ( !ejbVersion.matches( "\\A[2-4]\\.[0-9]\\z" ) )

Review comment:
       a unit test would be easier to manage than an integration test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org