[GitHub] [thrift] fishy opened a new pull request #2379: THRIFT-5404: Allow other types of TTransportException to be timeouts

[GitBox <gi...@apache.org>]

fishy opened a new pull request #2379:
URL: https://github.com/apache/thrift/pull/2379


   Client: go
   
   Currently we only treat TTransportException with typeId == TIMED_OUT to
   return true in Timeout function. When opening a new socket, if we got a
   connect timeout from net.Dial, we wrap the error as TTransportException
   with typeId == NOT_OPEN, thus it's no longer treated as a timeout error.
   
   Change the error to be directly wrapping the original error (instead of
   recreate a new error with the same error message), and change
   tTransportException.Exception to also return true if the wrapped error
   is a timeout error. This way we don't have to break anything (if code
   rely on TTransportException.TypeId being NOT_OPEN in this case, that's
   still true).
   
   While I'm here, also update CHANGES.md from #2359.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy merged pull request #2379: THRIFT-5404: Allow other types of TTransportException to be timeouts

[GitBox <gi...@apache.org>]

fishy merged pull request #2379:
URL: https://github.com/apache/thrift/pull/2379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org