You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "spmallette (via GitHub)" <gi...@apache.org> on 2026/08/04 16:57:00 UTC
[PR] Clarify addE()-step from()/to() semantics in reference docs [tinkerpop]
spmallette opened a new pull request, #3609:
URL: https://github.com/apache/tinkerpop/pull/3609
The AddE Step section of the reference documentation had a few gaps that made the `from()`/`to()` behavior hard to learn from the examples alone:
- Callouts 5 and 6 carried **identical** prose ("directed (detached) vertex references") even though they show fundamentally different patterns. `g.V(vMarko).addE('knows').to(vPeter)` uses the incoming traverser as the implicit from-vertex, whereas `g.addE('knows').from(vMarko).to(vPeter)` spawns the edge from `g` — where there is no traverser to act as a default endpoint, so both endpoints must be stated explicitly. The two callouts are now distinct and explain that distinction.
- The `from()`/`to()` argument forms were demonstrated but never stated as a rule. Added a short introductory note documenting the two canonical forms (a step-label string and a child traversal), and clarifying that passing a `Vertex` object directly is convenience syntax exposed by the language variant (e.g. Gremlin-Java, which resolves the `Vertex` to its id) rather than canonical Gremlin.
- The cumulative nature of the example block (each `addE()` persists and edge ids accumulate line to line) was never mentioned; added a note.
- Callout 2's stated edge direction was reversed: the query produces `lop->josh` and `ripple->josh`, but the prose read "from the josh-vertex to the lop- and ripple-vertices." Corrected.
Only the AddE Step section prose/callouts were touched; the live examples are unchanged and still render the same output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify addE()-step from()/to() semantics in reference docs [tinkerpop]
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette merged PR #3609:
URL: https://github.com/apache/tinkerpop/pull/3609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify addE()-step from()/to() semantics in reference docs [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3609:
URL: https://github.com/apache/tinkerpop/pull/3609#issuecomment-5183343306
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3609?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.06%. Comparing base ([`a28cd1f`](https://app.codecov.io/gh/apache/tinkerpop/commit/a28cd1f2f1f10c140030a56de44c5c6c045af5f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c89e0a2`](https://app.codecov.io/gh/apache/tinkerpop/commit/c89e0a276c06d41c2c87ca48cc7ac162c177ac17?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 427 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3609 +/- ##
============================================
- Coverage 76.35% 76.06% -0.30%
- Complexity 13424 14299 +875
============================================
Files 1012 1004 -8
Lines 60341 57707 -2634
Branches 7075 7664 +589
============================================
- Hits 46076 43892 -2184
+ Misses 11548 11049 -499
- Partials 2717 2766 +49
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/tinkerpop/pull/3609?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org