You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@twill.apache.org by anew <gi...@git.apache.org> on 2015/01/26 20:26:17 UTC

[GitHub] incubator-twill pull request: (TWILL-80) Perform log force flush c...

Github user anew commented on the pull request:

    https://github.com/apache/incubator-twill/pull/20#issuecomment-71520988
  
    The changes look good to me. Though it is a lot of refactoring, and hard to verify that the new code actually does what the previous code did, but with correct ordering of services lifecycle. Nice new test case to validate that it actually fixes this bug. 
    
    +1 provided all tests pass. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---