You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/29 16:46:23 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #8143:
[Codemod] Rename react unsafe lifecycles
etr2460 opened a new pull request #8143: [Codemod] Rename react unsafe lifecycles
URL: https://github.com/apache/incubator-superset/pull/8143
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Cleans up some of these console warnings:
Ran `npx react-codemod rename-unsafe-lifecycles` in `superset/assets/src` and `superset/assets/spec`.
However, we still have a decent number of dependencies that we'll need to update prior to being able to use React 17. This can be pushed off for a while (because React 17 isn't even out yet), but at some point, we'll have to pay the piper and upgrade a bunch of stuff. This'll include (I think) moving to a newer version of Bootstrap and finding a new React virtualizable library, as well as a bunch of other changes. No actions needed yet, but we'll wanna keep this on the future radar.
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Ensure dashboards, charts, and SQL Lab still work as expected. CI/Tests
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@graceguo-supercat @kristw @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org