You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/21 13:46:05 UTC

[GitHub] [arrow] cyb70289 commented on pull request #8879: ARROW-10797: [C++] Vendor and use PCG random generator library

cyb70289 commented on pull request #8879:
URL: https://github.com/apache/arrow/pull/8879#issuecomment-824073798


   Should be the MinGW32 rounding issue we met with many times before.
   Guess PCG generator produces different random numbers than std::default_random_engine. So this issue is always there, just not revealed by previous test data.
   I think we can disable the random test for MinGW32. ASSERT_DOUBLE_EQ expects at most 4ULP diff, it's almost there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org