You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mi...@apache.org on 2018/06/04 16:30:01 UTC
[2/5] impala git commit: IMPALA-7104: test_bloom_wait_time failing
with timeout on asan
IMPALA-7104: test_bloom_wait_time failing with timeout on asan
test_bloom_wait_time checks that its query runs in less than a certain
amount of time, to ensure we aren't waiting on bloom filters that will
never arrive.
The test sometimes goes slightly over the timeout and fails on ASAN.
This patch uses a specific_build_type_timeout to extend the allowed
timeout for ASAN.
It also fixes a bug in a similar test where we were comparing a
duration in seconds to a timeout in milliseconds, and renames some
variables to make it clearer why this was a bug.
Change-Id: I0271eb83e65b3b5f17e32f6501032f0d12dde38e
Reviewed-on: http://gerrit.cloudera.org:8080/10565
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/a8974406
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/a8974406
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/a8974406
Branch: refs/heads/2.x
Commit: a8974406aafe0f34bd045e90b60397e3eea79a1a
Parents: 6482021
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
Authored: Thu May 31 15:13:42 2018 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Jun 1 06:22:29 2018 +0000
----------------------------------------------------------------------
tests/query_test/test_runtime_filters.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/a8974406/tests/query_test/test_runtime_filters.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_runtime_filters.py b/tests/query_test/test_runtime_filters.py
index 38fd7a5..547a1ee 100644
--- a/tests/query_test/test_runtime_filters.py
+++ b/tests/query_test/test_runtime_filters.py
@@ -54,8 +54,8 @@ class TestRuntimeFilters(ImpalaTestSuite):
mode"""
now = time.time()
self.run_test_case('QueryTest/runtime_filters_wait', vector)
- duration = time.time() - now
- assert duration < WAIT_TIME_MS, \
+ duration_s = time.time() - now
+ assert duration_s < (WAIT_TIME_MS / 1000), \
"Query took too long (%ss, possibly waiting for missing filters?)" % str(duration)
def test_file_filtering(self, vector):
@@ -91,8 +91,8 @@ class TestBloomFilters(ImpalaTestSuite):
mode"""
now = time.time()
self.run_test_case('QueryTest/bloom_filters_wait', vector)
- duration = time.time() - now
- assert duration < 60, \
+ duration_s = time.time() - now
+ assert duration_s < (WAIT_TIME_MS / 1000), \
"Query took too long (%ss, possibly waiting for missing filters?)" % str(duration)