[GitHub] [trafficserver] rob05c commented on a change in pull request #7864: Do not invalidate cached resources upon error responses

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #7864:
URL: https://github.com/apache/trafficserver/pull/7864#discussion_r636474120



##########
File path: proxy/http/HttpTransact.cc
##########
@@ -288,24 +288,26 @@ is_localhost(const char *name, int len)
   return (len == (sizeof(local) - 1)) && (memcmp(name, local, len) == 0);
 }
 
+/** Return whether the response code indicates an error response. */
 inline static bool
-is_response_simple_code(HTTPStatus response_code)
+is_response_error_code(HTTPStatus response_code)

Review comment:
       Is it theoretically valid for this to ever be different than `is_response_simple_code(response_code) || is_response_unavailable_code(response_code)` ?
   If not, would it be better to make it that, to avoid duplication, one of them getting out of sync, etc?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org