[jira] [Commented] (BEAM-3368) Go model pipeline doesn't support External transform

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318897#comment-16318897 ] 

ASF GitHub Bot commented on BEAM-3368:
--------------------------------------

aaltay closed pull request #4284: BEAM-3368 fix translation for external
URL: https://github.com/apache/beam/pull/4284
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/go/pkg/beam/core/runtime/graphx/translate.go b/sdks/go/pkg/beam/core/runtime/graphx/translate.go
index f8cfc69227a..4d102f27250 100644
--- a/sdks/go/pkg/beam/core/runtime/graphx/translate.go
+++ b/sdks/go/pkg/beam/core/runtime/graphx/translate.go
@@ -238,6 +238,9 @@ func (m *marshaller) makePayload(edge *graph.MultiEdge) *pb.FunctionSpec {
 	case graph.GBK:
 		return &pb.FunctionSpec{Urn: urnGBK}
 
+	case graph.External:
+		return &pb.FunctionSpec{Urn: edge.Payload.URN, Payload: edge.Payload.Data}
+
 	default:
 		panic(fmt.Sprintf("Unexpected opcode: %v", edge.Op))
 	}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Go model pipeline doesn't support External transform
> ----------------------------------------------------
>
>                 Key: BEAM-3368
>                 URL: https://issues.apache.org/jira/browse/BEAM-3368
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Bill Neubauer
>            Assignee: Bill Neubauer
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The model pipeline translation process doesn't support the external transform, causing the translation process to panic when it encounters it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)