[GitHub] spark pull request #21476: [SPARK-24446][yarn] Properly quote library path f...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21476#discussion_r192295158
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -1485,6 +1486,22 @@ private object Client extends Logging {
         YarnAppReport(report.getYarnApplicationState(), report.getFinalApplicationStatus(), diagsOpt)
       }
     
    +  /**
    +   * Create a properly quoted library path string to be added as a prefix to the command executed by
    +   * YARN. This is different from plain quoting due to YARN executing the command through "bash -c".
    +   */
    +  def createLibraryPathPrefix(libpath: String, conf: SparkConf): String = {
    --- End diff --
    
    maybe pull this into a util class and have unit tests?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org