You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/20 05:06:44 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #15228: Improve skipping of DNS resolution when creating AuthenticationDataHttp instance

lhotari opened a new pull request, #15228:
URL: https://github.com/apache/pulsar/pull/15228

   ### Motivation
   
   - improves solution added in #15221
     - It's better to use the JDK provided `InetSocketAddress.createUnresolved` method
       to prevent unnecessary DNS resolution
   
   ### Modifications
   
   - use `InetSocketAddress.createUnresolved` method to prevent unnecessary DNS resolution
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15228: Improve skipping of DNS resolution when creating AuthenticationDataHttp instance

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15228:
URL: https://github.com/apache/pulsar/pull/15228#issuecomment-1103476628

   @lhotari:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #15228: Improve skipping of DNS resolution when creating AuthenticationDataHttp instance

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15228:
URL: https://github.com/apache/pulsar/pull/15228


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15228: Improve skipping of DNS resolution when creating AuthenticationDataHttp instance

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15228:
URL: https://github.com/apache/pulsar/pull/15228#issuecomment-1103475861

   @lhotari:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] michaeljmarshall commented on pull request #15228: Improve skipping of DNS resolution when creating AuthenticationDataHttp instance

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #15228:
URL: https://github.com/apache/pulsar/pull/15228#issuecomment-1106720307

   LGTM, +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15228: Improve skipping of DNS resolution when creating AuthenticationDataHttp instance

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15228:
URL: https://github.com/apache/pulsar/pull/15228#issuecomment-1103475865

   @lhotari:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org