You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/08 08:11:29 UTC

[GitHub] liubao68 commented on a change in pull request #692: [SCB-543]optimize registry procedure

liubao68 commented on a change in pull request #692: [SCB-543]optimize registry procedure
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/692#discussion_r186648174
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceRegisterTask.java
 ##########
 @@ -52,6 +53,11 @@ public void onMicroserviceInstanceHeartbeatTask(MicroserviceInstanceHeartbeatTas
     }
   }
 
+  @Subscribe
 
 Review comment:
   Just set 
   this.taskStatus = TaskStatus.READY;
   this.registered = false;
   
   like onMicroserviceInstanceHeartbeatTask

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services