[GitHub] [hop] hansva edited a comment on pull request #1252: HOP-3582 : Properties Input always requires a file

[GitBox <gi...@apache.org>]

hansva edited a comment on pull request #1252:
URL: https://github.com/apache/hop/pull/1252#issuecomment-1020522725


   Hi @uraychang I did some tests and though you did fix most of it there is one case that is still failing and should work.
   When only a single file has been added but it points to a non existing file and required is set to N then the transform should not fail and just finish as successful.
   
   I added an example pipeline integration-tests/transforms/0041-properties-file-input-invalid-file-required-no.hpl
   
   ![image](https://user-images.githubusercontent.com/1140235/150860083-9da01032-b95b-4c7e-8643-a71209b21135.png)
   
   Then you get following error:
   
   ```
   2022/01/24 21:32:57 - read non existing file required N.0 - ERROR: Unexpected error
   2022/01/24 21:32:57 - read non existing file required N.0 - ERROR: org.apache.hop.core.exception.HopException: 
   2022/01/24 21:32:57 - read non existing file required N.0 - No file(s) specified! Stop processing.
   2022/01/24 21:32:57 - read non existing file required N.0 - 
   2022/01/24 21:32:57 - read non existing file required N.0 - 	at org.apache.hop.pipeline.transforms.propertyinput.PropertyInput.processRow(PropertyInput.java:68)
   2022/01/24 21:32:57 - read non existing file required N.0 - 	at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:58)
   2022/01/24 21:32:57 - read non existing file required N.0 - 	at java.lang.Thread.run(Thread.java:748)
   ````
   
   When the required flag is set to Y it should fail (and this works)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org