You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/05/21 11:26:09 UTC

[GitHub] [cordova-plugin-splashscreen] ollm opened a new issue #311: Overlap with the new Android 12 SplashScreen API

ollm opened a new issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311


   # Bug Report
   
   In Android 12 now there are two splash screens, first from the SplashScreen API and then from the plugin.
   
   https://developer.android.com/about/versions/12/features/splash-screen
   https://developer.android.com/reference/android/window/SplashScreen
   
   ## Problem
   
   
   ### What is expected to happen?
   
   In Android 12 it should show only the splash screen from SplashScreen API.
   
   ### What does actually happen?
   Now there are two splash screens, first from the SplashScreen API and then from the plugin
   
   
   ## Information
   <!-- Include all relevant information that might help understand and reproduce the problem -->
   
   
   
   ### Command or Code
   <!-- What command or code is needed to reproduce the problem? -->
   
   
   
   ### Environment, Platform, Device
   <!-- In what environment, on what platform or on which device are you experiencing the issue? -->
   
   
   
   ### Version information
   <!-- 
   What are relevant versions you are using?
   For example:
   Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins 
   Other Frameworks: Ionic Framework and CLI version
   Operating System, Android Studio, Xcode etc.
   -->
   
   
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x] I searched for existing GitHub issues
   - [ ] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] hoatran2205 edited a comment on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
hoatran2205 edited a comment on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1076448458


   @terreng 
   
   App version
   node: v10.0.1
   ionic-native/splash-screen: v5.0.0
   cordova-android: v8.0.0
   cordova-plugin-splashscreen: 5.0.2
   
   In ionic source, I use "@ionic-native/splash-screen/ngx" to call function to hide splash screen 
   When build app, I use "ionic capacitor run android" to build Adroid app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] bhandaribhumin edited a comment on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
bhandaribhumin edited a comment on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-938598941


   @ollm I have fixed this using hook 
   create file splash_styles.xml
   ```
   <resources>
     <style name="SplashTheme" parent="android:Theme.Light">
     </style>
     <style name="Theme.RemoveSplashScreenTheme" parent="SplashTheme">
       <item name="android:windowIsTranslucent">true</item>
     </style>
   </resources>
   ```
   You have to add this file instance in AndroidManifest.xml at MainActivity section.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] hoatran2205 commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
hoatran2205 commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1076320651


   Hi there. I have an issue on Android 12 that SplashScreen didn't close when app init.
   My app can run with Android under 12. I used cordova-plugin-splashscreen but with android 12 it show error like:
   `Msg: Native: tried calling SplashScreen.hide, but the SplashScreen plugin is not installed.`  
   How can I solve this problem. Please help me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] bhandaribhumin commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
bhandaribhumin commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-938598941


   @ollm I have fix this using hook 
   
   create file splash_styles.xml
   ```
   <resources>
     <style name="SplashTheme" parent="android:Theme.Light">
     </style>
     <style name="Theme.RemoveSplashScreenTheme" parent="SplashTheme">
       <item name="android:windowIsTranslucent">true</item>
     </style>
   </resources>
   ```
   You have to add this file instance in AndroidManifest.xml at MainActivity section.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] terreng commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
terreng commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1076423713


   @hoatran2205 Hi there. It looks like you're using Ionic / Capacitor, [which is not compatible](https://capacitorjs.com/docs/v2/cordova/known-incompatible-plugins) with this plugin. Please let me know if I am mistaken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] bhandaribhumin commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
bhandaribhumin commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1038846806


   @terreng  if you need any help let me know, I'll help you on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] terreng commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
terreng commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1076473135


   @hoatran2205 If you are using Ionic / Capacitor, then you should be using the [Capacitor splashscreen API](https://capacitorjs.com/docs/apis/splash-screen). It sounds like the issue you are experiencing is related to Ionic / Capacitor, so I suggest you seek help elsewhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] ollm commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
ollm commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-938614183


   Thanks for the solution, I'll wait for now, since I would prefer to use the native Android 12 SpashScreen instead of the plugin.
   
   By the way, you should be able to add the reference to `AndroidManifest.xml` from `config.xml`, so you don't have to edit the `AndroidManifest.xml` file, and if you remove the android platform and add it again, the changes are kept.
   
   ``` xml
       <platform name="android">
           <resource-file src="pathtoxml/splash_styles.xml" target="app/src/main/res/drawable/splash_styles.xml" />
       </platform>
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] hoatran2205 edited a comment on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
hoatran2205 edited a comment on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1076448458






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] alanmilinovic commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
alanmilinovic commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1036339170


   Any news?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] hoatran2205 commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
hoatran2205 commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1076448458


   @terreng yes, I'm using  Ionic / Capacitor to build Android app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] terreng commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
terreng commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-1036363414


   Hi there. I added dark mode support for splash screens. This issue is on my to-do list, and I will look into it when I get the chance (no timeline, hopefully this year) if no one else has fixed it by then. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-splashscreen] bhandaribhumin commented on issue #311: Overlap with the new Android 12 SplashScreen API

Posted by GitBox <gi...@apache.org>.
bhandaribhumin commented on issue #311:
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/311#issuecomment-940768368


   Cordova-android10+  used Theme.AppCompact which is not compatible with our fix. 
   Hope soon plugin owner fix this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org