[GitHub] [iceberg] openinx commented on a change in pull request #2886: Flink: if provided, add uidPrefix to operator name so that Flink web …

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2886:
URL: https://github.com/apache/iceberg/pull/2886#discussion_r679095395



##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -209,21 +209,23 @@ public Builder equalityFieldColumns(List<String> columns) {
 
     /**
      * Set the uid prefix for FlinkSink operators. Note that FlinkSink internally consists of multiple operators (like
-     * writer, committer, dummy sink etc.) Actually operator uid will be appended with a suffix like "uid-writer".
-     * <p>
+     * writer, committer, dummy sink etc.) Actually operator uid will be appended with a suffix like "uidPrefix-writer".
+     * <br><br>
+     * If provided, this prefix is also applied to operator names.
+     * <br><br>
      * Flink auto generates operator uids if not set explicitly. It is a recommended
      * <a href="https://ci.apache.org/projects/flink/flink-docs-master/docs/ops/production_ready/">
      * best-practice to set uid for all operators</a> before deploying to production. Flink has an option to {@code
      * pipeline.auto-generate-uids=false} to disable auto-generation and force explicit setting of all operator uids.
-     * <p>
+     * <br><br>
      * Be careful with setting this for an existing job, because now we are changing the opeartor uid from an

Review comment:
       `opeartor` ?  typo ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org