You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2015/09/17 16:51:32 UTC

[GitHub] flink pull request: [FLINK-2576] Add Outer Join operator to Optimi...

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1138#issuecomment-141111654
  
    @jkovacs and @r-pogalz, thank you very much for this PR and the detailed description!
    It's quite a bit of code so it will take some time to be reviewed. I hope to give feedback soon.
    
    Nonetheless, we can start a discussion about the handling of projection for outer joins. By changing the type information to `GenericTypeInfo<TupleX>` to support tuples with null values, a `DataSet<TupleX>` cannot be used (in a join, groupBy, reduce, ...) as before because the runtime will use completely different serializers and comparators. Therefore, I am more in favor of not supporting projection for outer joins.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---