You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "renato-bohler (via GitHub)" <gi...@apache.org> on 2023/12/02 17:28:52 UTC
[PR] [UI] Adds support for CTRL key as a modifier for Query shortcuts [pinot]
renato-bohler opened a new pull request, #12087:
URL: https://github.com/apache/pinot/pull/12087
This PR includes a simple UI enhancement, adding support for the CTRL key as a modifier on the Query page (for Windows and Linux users).
The feature was originally added on https://github.com/apache/pinot/pull/7359, but only included support for the `event.metaKey` modifier, which maps to the ⌘ key on MacOS, but really can't be used as a modifier for Windows/Linux users.
https://github.com/apache/pinot/blob/949083d8b4903cd187660aaba5d0dd55bf7c85d0/pinot-controller/src/main/resources/app/pages/Query.tsx#L216-L225
With the implementation on this PR, MacOS users could use either the Cmd (⌘) or Control (^) as modifiers.
Closes https://github.com/apache/pinot/issues/12086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [UI] Adds support for CTRL key as a modifier for Query shortcuts [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #12087:
URL: https://github.com/apache/pinot/pull/12087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org