You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/09/17 16:50:04 UTC
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6221: Refactor the tm-health-client
zrhoffman commented on a change in pull request #6221:
URL: https://github.com/apache/trafficcontrol/pull/6221#discussion_r710501506
##########
File path: tc-health-client/README.md
##########
@@ -171,11 +171,11 @@ Sample configuarion file:
# Files
-* /etc/trafficcontrol-cache-config/tm-health-client.json
Review comment:
Does the t3c RPM still need to create the `/etc/trafficcontrol-cache-config` directory?
https://github.com/apache/trafficcontrol/blob/3e4aa4806f99737bc1e7c067950c9f8a6acd320f/cache-config/build/trafficcontrol-cache-config.spec#L136
##########
File path: tc-health-client/README.md
##########
@@ -171,11 +171,11 @@ Sample configuarion file:
# Files
-* /etc/trafficcontrol-cache-config/tm-health-client.json
-* /etc/logrotate.d/tm-health-client-logrotate
-* /usr/bin/tm-health-client
-* /usr/lib/systemd/system/tm-health-client.service
-* /var/log/trafficcontrol-cache-config/tm-health-client.json
+* /etc/trafficcontrol-health-client/tc-health-client.json
+* /etc/logrotate.d/tc-health-client-logrotate
+* /usr/bin/tc-health-client
+* /usr/lib/systemd/system/tc-health-client.service
+* /var/log/trafficcontrol-health-client/tc-health-client.json
Review comment:
Are `/etc/trafficcontrol-health-client` and `/var/log/trafficcontrol-health-client` preferable to `/etc/trafficcontrol/health-client` and `/var/log/trafficcontrol/health-client`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org