You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 17:32:14 UTC

[GitHub] [flink-kubernetes-operator] SteNicholas opened a new pull request #60: [FLINK-26552] Try to use @EnableKubernetesMockClient(crud = true) in controller test

SteNicholas opened a new pull request #60:
URL: https://github.com/apache/flink-kubernetes-operator/pull/60


   The controller test currently uses the `KubernetesMockserver` directly. We could try to use `@EnableKubernetesMockClient(crud = true)` in the `FlinkDeploymentControllerTest` test.
   
   **The brief change log**
   
   - Adds the `@EnableKubernetesMockClient(crud = true)` annotation to `FlinkDeploymentControllerTest` and removes the `KubernetesMockserver` and `KubernetesClient` initialization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #60: [FLINK-26552] Try to use @EnableKubernetesMockClient(crud = true) in controller test

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #60:
URL: https://github.com/apache/flink-kubernetes-operator/pull/60#issuecomment-1067304304


   But I can also do that in a followup :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora merged pull request #60: [FLINK-26552] Try to use @EnableKubernetesMockClient(crud = true) in controller test

Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #60:
URL: https://github.com/apache/flink-kubernetes-operator/pull/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #60: [FLINK-26552] Try to use @EnableKubernetesMockClient(crud = true) in controller test

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #60:
URL: https://github.com/apache/flink-kubernetes-operator/pull/60#issuecomment-1067303453


   I think with this change you could also remove the mockserver related logic from the beginning of the `testUpgradeNotReadyCluster` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org