You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/10/02 10:48:03 UTC
[jira] [Commented] (AIRFLOW-891) Webserver Clock Should Include Day
[ https://issues.apache.org/jira/browse/AIRFLOW-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187858#comment-16187858 ]
ASF subversion and git services commented on AIRFLOW-891:
---------------------------------------------------------
Commit 6895483ee442b08a08179d84724610a2c7ea4ee9 in incubator-airflow's branch refs/heads/master from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=6895483 ]
[AIRFLOW-891] Make webserver clock include date
Currently the webserver clock has only hour and
minute.
We change the clock format to "yyyy-MM-dd
HH:mm:ss",
because date information is helpful for user and
this format is universal.
Dear Airflow maintainers,
Please accept this PR. I understand that it will
not be reviewed until I have checked off all the
steps below!
### JIRA
- [x] My PR addresses the following [Airflow JIRA]
(https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For
example, "[AIRFLOW-XXX] My Airflow PR"
-
https://issues.apache.org/jira/browse/AIRFLOW-891
### Description
- [x] Here are some details about my PR, including
screenshots of any UI changes:
Currently the webserver clock has only hour and
minute.
We change the clock format to "yyyy-MM-dd
HH:mm:ss",
because date information is helpful for user and
this format is universal.
I updated jqClock.min.js with the latest version
for now
(https://github.com/JohnRDOrazio/jQuery-Clock-
Plugin/tree/v2.3.0).
<img width="1152" alt="screen shot 2017-06-26 at 1
38 16" src="https://user-images.githubusercontent.
com/898388/27517983-9e676122-5a10-11e7-90e1-db1e16
e931d8.png">
### Tests
- [x] My PR adds the following unit tests __OR__
does not need testing for this extremely good
reason:
Added no test. Instead, I ran webserver manually
and confirmed the clock was displayed expectedly.
Also, I confirmed all unit tests passed.
### Commits
- [x] My commits all reference JIRA issues in
their subject lines, and I have squashed multiple
commits if they address the same issue. In
addition, my commits follow the guidelines from
"[How to write a good git commit
message](http://chris.beams.io/posts/git-
commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not
"adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Closes #2399 from sekikn/AIRFLOW-891
> Webserver Clock Should Include Day
> ----------------------------------
>
> Key: AIRFLOW-891
> URL: https://issues.apache.org/jira/browse/AIRFLOW-891
> Project: Apache Airflow
> Issue Type: Improvement
> Components: webserver
> Reporter: Dan Davydov
> Assignee: Kengo Seki
> Priority: Minor
> Labels: beginner, starter
> Fix For: 1.9.0
>
>
> Currently the webserver clock shows "23:29 UTC" Ideally it would show the day as well, like 21-23:29 UTC.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)