You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/22 19:37:59 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #27021: Remove extra__kubernetes__ prefix from k8s hook extras

dstandish commented on code in PR #27021:
URL: https://github.com/apache/airflow/pull/27021#discussion_r1002564901


##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -141,6 +135,11 @@ def conn_extras(self):
         return extras
 
     def _get_field(self, field_name):
+        """
+        Prior to Airflow 2.3, in order to make use of UI customizations for extra fields,
+        we needed to store them with the prefix ``extra__kubernetes__``. This method
+        handles the backcompat, i.e. if the extra dict contains prefixed fields.
+        """
         if field_name.startswith('extra_'):

Review Comment:
   ```suggestion
           if field_name.startswith('extra__'):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org