[GitHub] [incubator-superset] john-bodley opened a new pull request #8722: [fix] Remedying filter-box w/ invalid metrics

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #8722: [fix] Remedying filter-box w/ invalid metrics
URL: https://github.com/apache/incubator-superset/pull/8722
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR fixes an issue where if the filter box referenced an obsolete value it would throw an exception when trying to sort the values (see before and after). Afterwards the error is shown, e.g. `Metric 'count' does not exist' however it is not apparent which filter this applies to as undefined values are filtered out from the set of options. 
   
   The solution is to add any saved values to the default options. Note ideally there would be some frontend validation which would propagate upwards and thus prevent the query from being run in the first place.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before 
   <img width="1426" alt="Screen Shot 2019-12-02 at 4 34 11 PM" src="https://user-images.githubusercontent.com/4567245/70006345-9c621880-1521-11ea-8ed6-b40183555ce1.png">
   
   #### After
   
   <img width="1430" alt="Screen Shot 2019-12-02 at 4 07 59 PM" src="https://user-images.githubusercontent.com/4567245/70006261-560cb980-1521-11ea-8d50-4f4fa9005e9e.png">
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org